Skip to content

Add "Azure" to DNS advisory check #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Add "Azure" to DNS advisory check #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions bbl-up/task
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,15 @@ function main() {
${name_flag} \
${lb_flags} "2>&1" ${drain} "${root_dir}/bbl_up.log"

ns_record_advisory="For DNS delegation to work, please ensure an NS record for ${LB_DOMAIN} is created in its parent DNS zone with the following nameservers:"
echo "For DNS delegation to work, please ensure an NS record for ${LB_DOMAIN} is created in its parent DNS zone with the following nameservers:"
if [[ "$BBL_IAAS" == "aws" ]]; then
echo "$ns_record_advisory"
bbl outputs | yq '.env_dns_zone_name_servers[0:4]' --output-format yaml | cut -d' ' -f2
elif [[ "$BBL_IAAS" == "gcp" ]]; then
echo "$ns_record_advisory"
bbl outputs | yq '.system_domain_dns_servers' --output-format yaml | cut -d' ' -f2
elif [[ "$BBL_IAAS" == "gcp" || "$BBL_IAAS" == "azure" ]]; then
if bbl outputs | yq '.system_domain_dns_servers' | grep -qv 'null'; then
bbl outputs | yq '.system_domain_dns_servers' --output-format yaml | cut -d' ' -f2
else
echo "No .system_domain_dns_servers found in bbl outputs. Please refer to the GCP/Azure portal to get the DNS servers for the created DNS zone."
fi
fi

if [[ "${DELETE_TERRAFORM_PLUGINS}" == "true" ]]; then
Expand Down