Skip to content

Conversation

@marckhouzam
Copy link

@marckhouzam marckhouzam commented Oct 3, 2025

Description of the Change

  1. remove the mention of rename-buildpack
  2. change delete-plugin-repo with remove-plugin-repo
  3. change delete-routes to delete-route

"rename-buildpack" no longer exists as a command: it was removed by commit ba9cea0.

Note that the command is still part of the command/common/internal/help_all_display.go file but when I try cf help -a there is an empty line where I would have expected to see this command. I'm not exactly sure what kind of magic is going on there.

Why Is This PR Valuable?

Showing invalid commands in theSEE ALSO` section of the help is wrong and confusing

How Urgent Is The Change?

Not urgent.

@marckhouzam
Copy link
Author

I will fix the integration tests as soon as I find time.

@marckhouzam marckhouzam force-pushed the marck/noRenameBuildpack branch from 5985b93 to a6d6368 Compare October 3, 2025 12:34
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment but otherwise LGTM once the integration test is fixed.

"rename-buildpack" no longer exists as a command: it was removed by
commit ba9cea0.

Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam force-pushed the marck/noRenameBuildpack branch from a6d6368 to 7966af0 Compare October 17, 2025 12:51
@marckhouzam marckhouzam changed the title Remove mention of rename-buildpack in related cmds Fix invalid related commands Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants