Improve error messaging for creating a Deployment that will violate quotas with high max-in-flight

[nookala]

Fix error message to be more descriptive

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

• A short explanation of the proposed change:
  When creating a Deployment, it can be unclear that a quota violation is due to a high max-in-flight. Enhance the error message with better description and suggestions for remediation.

Previously the error was "memory space_quota_exceeded". With the change it's "memory space_quota_exceeded for space space1. This space's quota may not be large enough to support rolling deployments or your configured max-in-flight."
For an org level quota error after change is as follows "memory quota_exceeded for organization org1. This organization's quota may not be large enough to support rolling deployments or your configured max-in-flight."

• An explanation of the use cases your change solves

• Links to any other associated PRs

• I have reviewed the contributing guide

• I have viewed, signed, and submitted the Contributor License Agreement

• I have made this pull request to the main branch

• I have run all the unit tests using bundle exec rake

• I have run CF Acceptance Tests

[sethboyles]

nit instead of making symbols and turning them to Strings, you could make an array of literals with this syntax:

%w(space_quota_exceeded space_app_instance_limit_exceeded)

[sethboyles]

I wonder if it's worth all this extra logic to make the space/org distinction. What if you checked for any quota error and simply added One or more quotas may not be large enough to support rolling deployments or your configured max-in-flight. to then end? Could simplify the code a bunch. What do you think?

[sethboyles]

Tested this out:

Creating deployment for app dora...

memory space_quota_exceeded, memory quota_exceeded, app_instance_limit space_app_instance_limit_exceeded, log_rate_limit exceeds space log rate quota for space space. This space's quota may not be large enough to support rolling deployments or your configured max-in-flight.
FAILED

Definitely is more helpful in the context of deployments. 👍