Skip to content

Explicitly hint the data source config about the postgresql driver #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IvanBorislavovDimitrov
Copy link
Contributor

@IvanBorislavovDimitrov IvanBorislavovDimitrov commented Jun 11, 2024

Tested with UPS that is created by the binding from another app. UPS example:
{
"dbname":"db-name",
"hostname":"",
"password":"",
"port":"",
"sslcert":"",
"sslrootcert":"",
"uri":"",
"username":""
}

The DB name must be deploy-service databae

Copy link

Copy link
Contributor

@boyan-velinov boyan-velinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

@bonzofenix
Copy link

@IvanBorislavovDimitrov
Copy link
Contributor Author

hi @bonzofenix,
the username, password and uri are mandatory only

@bonzofenix
Copy link

@IvanBorislavovDimitrov yes, provisioning the user-provided-service with -t postgres allows the java oss buildpack to provision the missing Postgres drivers without the changes in this pr, with what is in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants