-
Notifications
You must be signed in to change notification settings - Fork 44
Add audit logs #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stiv03
wants to merge
1
commit into
cloudfoundry:master
Choose a base branch
from
stiv03:add-audit-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add audit logs #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yavor16
requested changes
Jul 11, 2025
...g/cloudfoundry/multiapps/controller/core/auditlogging/ConfigurationEntryServiceAuditLog.java
Outdated
Show resolved
Hide resolved
...g/cloudfoundry/multiapps/controller/core/auditlogging/ConfigurationEntryServiceAuditLog.java
Outdated
Show resolved
Hide resolved
...g/cloudfoundry/multiapps/controller/core/auditlogging/ConfigurationEntryServiceAuditLog.java
Outdated
Show resolved
Hide resolved
...ava/org/cloudfoundry/multiapps/controller/core/auditlogging/model/AuditLogConfiguration.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/core/util/ApplicationConfiguration.java
Show resolved
Hide resolved
.../test/java/org/cloudfoundry/multiapps/controller/core/util/ApplicationConfigurationTest.java
Outdated
Show resolved
Hide resolved
@@ -20,8 +20,6 @@ | |||
import org.cloudfoundry.multiapps.controller.persistence.query.impl.ConfigurationEntryQueryImpl; | |||
import org.cloudfoundry.multiapps.mta.model.Version; | |||
|
|||
import com.fasterxml.jackson.core.type.TypeReference; | |||
|
|||
@Named | |||
public class ConfigurationEntryService extends PersistenceService<ConfigurationEntry, ConfigurationEntryDto, Long> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exclude this class for the PR because here you don't change anything
import java.util.Map; | ||
|
||
import static java.text.MessageFormat.format; | ||
|
||
@Named | ||
public class ConfigurationSubscriptionService extends PersistenceService<ConfigurationSubscription, ConfigurationSubscriptionDto, Long> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this class also
ikasarov
reviewed
Jul 11, 2025
...ava/org/cloudfoundry/multiapps/controller/core/auditlogging/model/AuditLogConfiguration.java
Show resolved
Hide resolved
...cloudfoundry/multiapps/controller/persistence/services/ConfigurationSubscriptionService.java
Outdated
Show resolved
Hide resolved
...rg/cloudfoundry/multiapps/controller/core/auditlogging/ApplicationConfigurationAuditLog.java
Show resolved
Hide resolved
...g/cloudfoundry/multiapps/controller/core/auditlogging/ConfigurationEntryServiceAuditLog.java
Outdated
Show resolved
Hide resolved
...foundry/multiapps/controller/core/auditlogging/ConfigurationSubscriptionServiceAuditLog.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/core/util/ApplicationConfiguration.java
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/core/util/ApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
a05a6e6
to
a08e30e
Compare
Yavor16
requested changes
Jul 15, 2025
...rc/main/java/org/cloudfoundry/multiapps/controller/core/auditlogging/AuditLoggingFacade.java
Outdated
Show resolved
Hide resolved
Yavor16
previously approved these changes
Jul 15, 2025
ikasarov
reviewed
Jul 18, 2025
.../src/main/java/org/cloudfoundry/multiapps/controller/core/util/ApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
ikasarov
approved these changes
Jul 18, 2025
LMCROSSITXSADEPLOY-3159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.