File based bindings #1669
Open
File based bindings #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theghost5800
force-pushed
the
fileBasedBindings
branch
from
c7bd974 to
4ea6213
Compare
| @@ -39,7 +39,7 @@ | |||
| <jackson.databind.version>2.19.1</jackson.databind.version> | |||
| <liquibase.version>4.32.0</liquibase.version> | |||
| <liquibase-slf4j.version>5.1.0</liquibase-slf4j.version> | |||
| <cloudfoundry-client.version>2.58.0</cloudfoundry-client.version> | |||
Comment on lines
+45
to
+51
| Map<String, Boolean> appFeatures = (Map<String, Boolean>) PropertiesUtil.getPropertyValue(parametersList, | ||
| SupportedParameters.APP_FEATURES, | ||
| Collections.emptyMap()); | ||
| Map<String, Boolean> appFeaturesWithOverriddenSsh = new HashMap<>(appFeatures); | ||
| if (isSshEnabled != null && !appFeatures.containsKey(Constants.APP_FEATURE_SSH)) { | ||
| appFeaturesWithOverriddenSsh.put(Constants.APP_FEATURE_SSH, isSshEnabled); | ||
| } |
There was a problem hiding this comment.
Please extract this logic in separate method like:
Map<String, Boolean> appFeatures = getNormalizedAppFeatures(parametersList, isSshEnabled);
Also do we need to use two Map objects?
| // (48) app-features parameter with multiple features enabled/disabled | ||
| Arguments.of( | ||
| "/mta/app-features/mtad-app-features.yaml", "/mta/app-features/config-app-features.mtaext", "/mta/cf-platform.json", null, null, false, | ||
| new String[] { "feature-app" }, // mtaArchiveModules |
|
|
||
| private static Stream<Arguments> testIsValid() { | ||
| return Stream.of( | ||
| // (1) All features are boolean |
| </extensionElements> | ||
| </callActivity> | ||
| <sequenceFlow id="sid-26C87D1E-88D5-47E3-907B-0F8EBBCD2C36" sourceRef="executeTasksCallActivity" targetRef="publishProvidedDependenciesTask"></sequenceFlow> | ||
| <callActivity id="hooksCallActivity" name="Execute Hooks Call Activity" flowable:async="true" calledElement="${hookProcessGetter.get(hookForExecution, execution)}" flowable:calledElementType="key" flowable:inheritVariables="false" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false"> |
There was a problem hiding this comment.
why this is removed inheritVariables="false"
| </extensionElements> | ||
| <multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"></multiInstanceLoopCharacteristics> | ||
| <multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"> | ||
| <extensionElements></extensionElements> |
| @@ -120,23 +122,25 @@ | |||
| <sequenceFlow id="sid-74CBBBDE-B4B8-451B-8193-8B1A08835E23" sourceRef="publishProvidedDependenciesTask" targetRef="shouldDeleteIdleRoutes"></sequenceFlow> | |||
| <sequenceFlow id="flow90" sourceRef="exclusivegateway6" targetRef="timerintermediatecatchevent3"></sequenceFlow> | |||
| <sequenceFlow id="sid-EDE0C6AF-FE13-4120-94B8-406BFCE8A407" sourceRef="stopAppTask" targetRef="hooksCallActivity"></sequenceFlow> | |||
| <callActivity id="sid-F6B2FD75-29A0-4347-B49F-94B4CD7C1469" name="Execute Hooks Call Activity" flowable:async="true" calledElement="${hookProcessGetter.get(hookForExecution, execution)}" flowable:calledElementType="key" flowable:inheritVariables="false" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false"> | |||
| </extensionElements> | ||
| <multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"></multiInstanceLoopCharacteristics> | ||
| <multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"> | ||
| <extensionElements></extensionElements> |
| <omgdi:waypoint x="143.0" y="917.9401335311574"></omgdi:waypoint> | ||
| <omgdi:waypoint x="143.0" y="999.0"></omgdi:waypoint> | ||
| <omgdi:waypoint x="141.0" y="999.0"></omgdi:waypoint> | ||
| <omgdi:waypoint x="141.0" y="1126.0"></omgdi:waypoint> | ||
| <omgdi:waypoint x="140.1357142857143" y="1125.1360544217687"></omgdi:waypoint> |
There was a problem hiding this comment.
why the positions are changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.