-
Notifications
You must be signed in to change notification settings - Fork 44
File based bindings #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
File based bindings #1669
Conversation
c7bd974
to
4ea6213
Compare
@@ -39,7 +39,7 @@ | |||
<jackson.databind.version>2.19.1</jackson.databind.version> | |||
<liquibase.version>4.32.0</liquibase.version> | |||
<liquibase-slf4j.version>5.1.0</liquibase-slf4j.version> | |||
<cloudfoundry-client.version>2.58.0</cloudfoundry-client.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this
Map<String, Boolean> appFeatures = (Map<String, Boolean>) PropertiesUtil.getPropertyValue(parametersList, | ||
SupportedParameters.APP_FEATURES, | ||
Collections.emptyMap()); | ||
Map<String, Boolean> appFeaturesWithOverriddenSsh = new HashMap<>(appFeatures); | ||
if (isSshEnabled != null && !appFeatures.containsKey(Constants.APP_FEATURE_SSH)) { | ||
appFeaturesWithOverriddenSsh.put(Constants.APP_FEATURE_SSH, isSshEnabled); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extract this logic in separate method like:
Map<String, Boolean> appFeatures = getNormalizedAppFeatures(parametersList, isSshEnabled);
Also do we need to use two Map objects?
// (48) app-features parameter with multiple features enabled/disabled | ||
Arguments.of( | ||
"/mta/app-features/mtad-app-features.yaml", "/mta/app-features/config-app-features.mtaext", "/mta/cf-platform.json", null, null, false, | ||
new String[] { "feature-app" }, // mtaArchiveModules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract constants
|
||
private static Stream<Arguments> testIsValid() { | ||
return Stream.of( | ||
// (1) All features are boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract constants
</extensionElements> | ||
</callActivity> | ||
<sequenceFlow id="sid-26C87D1E-88D5-47E3-907B-0F8EBBCD2C36" sourceRef="executeTasksCallActivity" targetRef="publishProvidedDependenciesTask"></sequenceFlow> | ||
<callActivity id="hooksCallActivity" name="Execute Hooks Call Activity" flowable:async="true" calledElement="${hookProcessGetter.get(hookForExecution, execution)}" flowable:calledElementType="key" flowable:inheritVariables="false" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is removed inheritVariables="false"
</extensionElements> | ||
<multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"></multiInstanceLoopCharacteristics> | ||
<multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"> | ||
<extensionElements></extensionElements> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is added
@@ -120,23 +122,25 @@ | |||
<sequenceFlow id="sid-74CBBBDE-B4B8-451B-8193-8B1A08835E23" sourceRef="publishProvidedDependenciesTask" targetRef="shouldDeleteIdleRoutes"></sequenceFlow> | |||
<sequenceFlow id="flow90" sourceRef="exclusivegateway6" targetRef="timerintermediatecatchevent3"></sequenceFlow> | |||
<sequenceFlow id="sid-EDE0C6AF-FE13-4120-94B8-406BFCE8A407" sourceRef="stopAppTask" targetRef="hooksCallActivity"></sequenceFlow> | |||
<callActivity id="sid-F6B2FD75-29A0-4347-B49F-94B4CD7C1469" name="Execute Hooks Call Activity" flowable:async="true" calledElement="${hookProcessGetter.get(hookForExecution, execution)}" flowable:calledElementType="key" flowable:inheritVariables="false" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
</extensionElements> | ||
<multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"></multiInstanceLoopCharacteristics> | ||
<multiInstanceLoopCharacteristics isSequential="false" flowable:collection="hooksForExecution" flowable:elementVariable="hookForExecution"> | ||
<extensionElements></extensionElements> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
<omgdi:waypoint x="143.0" y="917.9401335311574"></omgdi:waypoint> | ||
<omgdi:waypoint x="143.0" y="999.0"></omgdi:waypoint> | ||
<omgdi:waypoint x="141.0" y="999.0"></omgdi:waypoint> | ||
<omgdi:waypoint x="141.0" y="1126.0"></omgdi:waypoint> | ||
<omgdi:waypoint x="140.1357142857143" y="1125.1360544217687"></omgdi:waypoint> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the positions are changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comments
No description provided.