yopass: add optional read-only deployment (-readonly)#705
Open
freinold wants to merge 1 commit into
Open
Conversation
freinold
commented
Jun 24, 2026
- Add .Values.readOnly.* and render second Deployment/Service/Ingress with -readonly suffix
- Add app.kubernetes.io/component labels/selectors to separate internal vs readonly
- Reuse global DB/metrics; keep single ServiceMonitor
- Update README.md.gotmpl with split deployment docs
- Add example values at ci/readonly-values.yaml
- Add .Values.readOnly.* and render second Deployment/Service/Ingress with -readonly suffix - Add app.kubernetes.io/component labels/selectors to separate internal vs readonly - Reuse global DB/metrics; keep single ServiceMonitor - Update README.md.gotmpl with split deployment docs - Add example values at ci/readonly-values.yaml
Member
|
Thanks for the contribution, this looks really great. If readonly is enabled I would prefer to suffix the internal deployment, service and ingress with |
Member
|
To have correct conventional commits I would squash the commits into |
Member
|
@freinold are you willing to spend more time on that? :) |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.