Skip to content

yopass: add optional read-only deployment (-readonly)#705

Open
freinold wants to merge 1 commit into
cloudhippie:masterfrom
freinold:feat/yopass-readonly-support
Open

yopass: add optional read-only deployment (-readonly)#705
freinold wants to merge 1 commit into
cloudhippie:masterfrom
freinold:feat/yopass-readonly-support

Conversation

@freinold

Copy link
Copy Markdown
  • Add .Values.readOnly.* and render second Deployment/Service/Ingress with -readonly suffix
  • Add app.kubernetes.io/component labels/selectors to separate internal vs readonly
  • Reuse global DB/metrics; keep single ServiceMonitor
  • Update README.md.gotmpl with split deployment docs
  • Add example values at ci/readonly-values.yaml

- Add .Values.readOnly.* and render second Deployment/Service/Ingress with -readonly suffix

- Add app.kubernetes.io/component labels/selectors to separate internal vs readonly

- Reuse global DB/metrics; keep single ServiceMonitor

- Update README.md.gotmpl with split deployment docs

- Add example values at ci/readonly-values.yaml
@tboerger

Copy link
Copy Markdown
Member

Thanks for the contribution, this looks really great. If readonly is enabled I would prefer to suffix the internal deployment, service and ingress with -internal, after that I would be happy to merge the change. To get this finally merged you need to increase the minor version, currently it would be 9.5.0.

@tboerger

tboerger commented Jun 24, 2026

Copy link
Copy Markdown
Member

To have correct conventional commits I would squash the commits into feat(yopass): add optional read-only deployment.

@tboerger

tboerger commented Jul 2, 2026

Copy link
Copy Markdown
Member

@freinold are you willing to spend more time on that? :)

@freinold

freinold commented Jul 2, 2026

Copy link
Copy Markdown
Author

@freinold are you willing to spend more time on that? :)

@tboerger yes, will do this/next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants