Skip to content

fix(ENG-2912): CLI typos and doc changes #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ralph-mcteggart
Copy link

I was originally looking here for a defect related to the CLI before realising the required changes were in the API.

When reading through the docs I noticed some inconsistencies so updated while I was here

(ENG-2912)

@chrisimcevoy
Copy link
Collaborator

chrisimcevoy commented Dec 14, 2023

@ralph-mcteggart Your tests are (false positive) timing out because they're waiting for "Fully Synchronised" (with an "s") to appear in the command output here

@ralph-mcteggart
Copy link
Author

@ralph-mcteggart Your tests are (false positive) timing out because they're waiting for "Fully Synchronised" (with an "s") to appear in the command output here

Cheers @chrisimcevoy! Was aware but haven't got round to fixing it. Appreciate the heads up though 😁

Copy link

codeclimate bot commented Dec 15, 2023

Code Climate has analyzed commit 99e0d00 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.5% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants