Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine document for opentelemetry-compile-time-instrumentation #1234

Merged
merged 9 commits into from
Feb 28, 2025

Conversation

123liuziming
Copy link
Contributor

update doc for hertz
update doc for kitex
update doc for hertz
update english doc
update english document for kitex
@123liuziming 123liuziming requested review from a team as code owners February 9, 2025 10:40
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 10:41am

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2025

CLA assistant check
All committers have signed the CLA.

@123liuziming 123liuziming changed the title [WIP] refine document for opentelemetry-compile-time-instrumentation refine document for opentelemetry-compile-time-instrumentation Feb 26, 2025
@123liuziming
Copy link
Contributor Author

@hi-pender @rogerogers Hi, could you please help me to review it? Thanks!

@rogerogers
Copy link
Contributor

OpenTelemetry, Alibaba, Datadog.

@123liuziming
Copy link
Contributor Author

OpenTelemetry, Alibaba, Datadog.

Do you mean to polish the typo in this PR?

@GuangmingLuo
Copy link
Member

Sorry, we won't add external enterprise solution links here for now @123liuziming

@123liuziming
Copy link
Contributor Author

Sorry, we won't add external enterprise solution links here for now @123liuziming

Ok, can I only add OpenTelemetry related infomation here?

@GuangmingLuo
Copy link
Member

ok

@123liuziming
Copy link
Contributor Author

External enterprise solution links are removed, all about OpenTelemetry

@GuangmingLuo GuangmingLuo merged commit 4b154cb into cloudwego:main Feb 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants