#297 support optional parameters for thrift functions

[kubroid]

Resolves #297

[CLAassistant]

All committers have signed the CLA.

[Millione]

@kubroid Hi, please sign the CLA first before we start the review!

[kubroid]

@Millione, done!

[PureWhiteWu]

Is this a breaking change for existing users that we must bump the version?

[kubroid]

In case using optional parameters it will break volo-build

[kubroid]

Of course its on you to decide if version change is essential. Also I'm not sure about Cargo.lock changes are required.

[PureWhiteWu]

Hello, I thought there's no one using this feature before, but I'm also not sure if we need to bump the minor version at this time.
Is depending on branch for you acceptable for you?

[kubroid]

I guess... There is only one project requires this feature at this moment and I'm not sure if more will come in future.

[PureWhiteWu]

Maybe we can just use branch at this moment? When there's more projects rely on this, we should have already published a new version lol.

[kubroid]

Sure, no problems from my side :)

[PureWhiteWu]

@kubroid Hi, could you please don't change the version, and then I think we can merge this?

[kubroid]

@PureWhiteWu sorry guys, company decided to not go rust, so, all this effort is a waste of time :((
if you still interested in this feature, I'll update the PR.

PS: thanks a lot for your help, it was fun.

[PureWhiteWu]

It's never a waste of time, thank you very much for helping us and the Rust open source community to be better.

Of course we'd like this pr to be merged, so could you please take some time to update this pr?

[kubroid]

@PureWhiteWu updated, please take a look.
I'm still not sure about if i need to commit a Carglo.lock changes.

[PureWhiteWu]

LGTM, thanks very much!

[Millione]

@kubroid It seems that you should run UPDATE_TEST_DATA=1 cargo test again to pass CI.

[kubroid]

@kubroid It seems that you should run UPDATE_TEST_DATA=1 cargo test again to pass CI.

thanks for the hint @Millione!
done

[Millione]

Thanks very much!