Skip to content

1225 integrate mirador js library #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

sandeep-ps
Copy link
Member

No description provided.

@sandeep-ps sandeep-ps self-assigned this Mar 20, 2025
@sandeep-ps sandeep-ps linked an issue Mar 20, 2025 that may be closed by this pull request
@@ -88,7 +88,7 @@ config["eventListenerJobStatus"]["skipped"] = "SKIPPED";
config["eventListenerJobStatus"]["resubmitted"] = "RESUBMITTED";

config["streamingBytes"] = 1024 * 10; // 10 MB?
config["rawDataVisualizationThreshold"] = 1024 * 1024 * 10; // 10 MB
config["rawDataVisualizationThreshold"] = 1024 * 1024 * 1024; // 1 GB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the default smaller?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I had planned to keep the previous default as is. This was accidentally committed. I will revert this change.

@@ -0,0 +1,18 @@
{
"name": "wsi-visualization",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to something more iiif generic? Since any image can be handled this way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense. I will change it to use IIIF instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also updating the visualization config MIME type to a custom one image/x-iiif. Please let me know if it needs to be kept as application/octet-stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Mirador JS library
2 participants