1225 integrate mirador js library #1232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep-ps
commented
Mar 27, 2025
lmarini
requested changes
Apr 17, 2025
frontend/src/app.config.ts
Outdated
| @@ -88,7 +88,7 @@ config["eventListenerJobStatus"]["skipped"] = "SKIPPED"; | |||
| config["eventListenerJobStatus"]["resubmitted"] = "RESUBMITTED"; | |||
|
|
|||
| config["streamingBytes"] = 1024 * 10; // 10 MB? | |||
| config["rawDataVisualizationThreshold"] = 1024 * 1024 * 10; // 10 MB | |||
| config["rawDataVisualizationThreshold"] = 1024 * 1024 * 1024; // 1 GB | |||
There was a problem hiding this comment.
Can we make the default smaller?
There was a problem hiding this comment.
Yes, I had planned to keep the previous default as is. This was accidentally committed. I will revert this change.
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "name": "wsi-visualization", | |||
There was a problem hiding this comment.
Can we rename this to something more iiif generic? Since any image can be handled this way?
There was a problem hiding this comment.
Yes, makes sense. I will change it to use IIIF instead.
There was a problem hiding this comment.
I'm also updating the visualization config MIME type to a custom one image/x-iiif. Please let me know if it needs to be kept as application/octet-stream.
…rough IIIF standard APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.