Potential fix for code scanning alert no. 6: Failure to use HTTPS URLs#24
Closed
bryantbiggs wants to merge 1 commit intomainfrom
Closed
Potential fix for code scanning alert no. 6: Failure to use HTTPS URLs#24bryantbiggs wants to merge 1 commit intomainfrom
bryantbiggs wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/clowdhaus/docker-registry/security/code-scanning/6
The best way to remediate this is to prevent the use of HTTP by default, and discourage or disable HTTP usage except in clearly-marked/test configurations. Changes required:
insecure_registrytofalse. (Already set, but highlight this in docs for clarity.)insecure_registryis set totruefor public registries. Optionally, block non-localhost/loopback values.insecure_registryis true and the registry hostname is not localhost/127.0.0.1.Concrete implementation steps:
build()method, before constructing the URL, check ifinsecure_registryis true and ifself.indexpoints to a non-localhost host (not 127.0.0.1 or localhost). If so, return an error.insecure_registryis true.Edits will only be to regions in src/v2/config.rs shown above, specifically lines around the URL schema selection in the
build()method.Suggested fixes powered by Copilot Autofix. Review carefully before merging.