Add Option: Combine Play/Pause buttons into one #3239
Closed
+152
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariosmant
changed the title
When video is playing and pause icon is highlighted, it will simply indicate video is in paused state. Which is wrong. So my suggestion is, it shouldn't highlight the play/pause button. Whenever mouse click will happen, it will show a clicking effect like other buttons. |
|
It sounds more reasonable to me, too. I guess there was a reason these buttons were defined as TBBS_CHECKGROUP. I added an extra commit to make it TBBS_BUTTON when this option is enabled, in order to act like a normal button. Hope it gets accepted as it is a needed feature. Now it behaves exactly as you say. |
Repository owner
deleted a comment from
giwrgosmant
Jan 27, 2025
Repository owner
locked and limited conversation to collaborators
Jan 28, 2025
Repository owner
deleted a comment from
giwrgosmant
Jan 28, 2025
Repository owner
deleted a comment from
Neustradamus
Jan 28, 2025
Repository owner
deleted a comment from
SPLESHER1
Jan 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced a new option in View->Options->Player->Other->"Combine Play/Pause buttons into one".
This option will merge "Play" and "Pause" buttons into one, so when the video is playing, it will appear as "Pause" (with pause icon), and vice versa. This option requires to restart the application in order to take effect.
This will cover the feature request: #2003