Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fiber tests to avoid now unneeded await() calls #118

Merged
merged 1 commit into from
Feb 19, 2022
+0 −15
Merged

Improve fiber tests to avoid now unneeded await() calls #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/AppTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,11 +877,6 @@ public function testHandleRequestWithMatchingRouteReturnsPromiseResolvingWithRes
"OK\n"
));

// await next tick: https://github.com/reactphp/async/issues/27
await(new Promise(function ($resolve) {
Loop::futureTick($resolve);
}));

/** @var ResponseInterface $response */
$this->assertInstanceOf(ResponseInterface::class, $response);
$this->assertEquals(200, $response->getStatusCode());
Expand Down Expand Up @@ -1152,11 +1147,6 @@ public function testHandleRequestWithMatchingRouteReturnsPromiseWhichFulfillsWit

$deferred->reject($exception);

// await next tick: https://github.com/reactphp/async/issues/27
await(new Promise(function ($resolve) {
Loop::futureTick($resolve);
}));

/** @var ResponseInterface $response */
$this->assertInstanceOf(ResponseInterface::class, $response);
$this->assertEquals(500, $response->getStatusCode());
Expand Down
5 changes: 0 additions & 5 deletions tests/FiberHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ public function testInvokeWithHandlerReturningResponseAfterAwaitingPendingPromis

$deferred->resolve($response);

// await next tick: https://github.com/reactphp/async/issues/27
await(new Promise(function ($resolve) {
Loop::futureTick($resolve);
}));

$this->assertSame($response, $ret);
}
}