Merged
Conversation
added 11 commits
January 30, 2026 17:48
kandrosov
requested changes
Feb 20, 2026
kandrosov
requested changes
Feb 21, 2026
| return self.trg_ | ||
|
|
||
| @property | ||
| def btag_norm(self): |
Contributor
There was a problem hiding this comment.
Suggested change
| def btag_norm(self): | |
| def btag_shapeNorm(self): |
to avoid possible confusions with WP-based btag SFs that directly correct "normalization" instead of the btag discriminator shape.
| self._InitCppMap(unc_src_scale) | ||
|
|
||
| df = df.Redefine( | ||
| "weight_bTagShape_Central", |
Contributor
There was a problem hiding this comment.
You should correct all btag-related up/down uncertainties, not only the central one
kandrosov
reviewed
Feb 24, 2026
kandrosov
approved these changes
Feb 25, 2026
Contributor
kandrosov
left a comment
kandrosov
left a comment
There was a problem hiding this comment.
tested with cms-flaf/FLAF#218
kandrosov
requested changes
Feb 25, 2026
| applier, | ||
| ["weight_bTagShape_Central", "btag_shape_norm_key_Central"], | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
We expect _rel branches to be relative, you need to divide them by central once central is redefined
kandrosov
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.