First ana prod from central nano bug fixes#40
Open
valeriadamante wants to merge 75 commits intocms-flaf:mainfrom
Open
First ana prod from central nano bug fixes#40valeriadamante wants to merge 75 commits intocms-flaf:mainfrom
valeriadamante wants to merge 75 commits intocms-flaf:mainfrom
Conversation
…omCentralNano_bugFixes
Contributor
Author
|
@cms-flaf-bot please test:
|
|
pipeline#14077617 started |
|
pipeline#14077617 failed |
Contributor
Author
|
@cms-flaf-bot please test |
|
pipeline#14084955 started |
|
pipeline#14084955 passed |
kandrosov
requested changes
Feb 19, 2026
config/global.yaml
Outdated
| category_definition: | ||
| no_cuts: "true" | ||
| baseline_WPIso_MM: "mu1_pfRelIso04_all < 0.2 && mu2_pfRelIso04_all< 0.2 && mu1_mediumId && mu2_mediumId" | ||
| mu_pt_sel: "mu1_{mu_pt_for_selection} > 20 && mu2_{mu_pt_for_selection} > 20" |
config/phys_models.yaml
Outdated
| - DY | ||
| - TT | ||
| - W_NJets | ||
| # - VV |
Collaborator
There was a problem hiding this comment.
- clean up commented processes
- Don't you need data for WP studies?
| return legs | ||
|
|
||
| def PassGenAcceptance(df): | ||
| def PassGenAcceptance(df):code |
Collaborator
There was a problem hiding this comment.
Suggested change
| def PassGenAcceptance(df):code | |
| def PassGenAcceptance(df): |
| df = df.Filter("Muon_idx[Muon_B0].size()==2", "Exactly 2 muons") | ||
| df = df.Define("mu1_idx", "Muon_idx[Muon_B0][0]") | ||
| df = df.Define("mu2_idx", "Muon_idx[Muon_B0][1]") | ||
| df = df.Filter("Muon_charge[mu1_idx]*Muon_charge[mu2_idx]<0", "OS muons") |
Collaborator
There was a problem hiding this comment.
Is the OS cut really needed at this level?
AnaProd/baseline.py
Outdated
| # # exactly two muons -- See AN/2019_185 line 118 and AN/2019_205 lines 246 | ||
| df = df.Filter("Muon_idx[Muon_B0].size()==2", "No extra muons") | ||
|
|
||
| df = df.Filter("Muon_idx[Muon_B0].size()==2", "Exactly 2 muons") |
Collaborator
There was a problem hiding this comment.
If you don't apply any muonID and iso requirement, you shouldn't be applying a veto at this stage. Applying a veto on all muons can lead to unwanted behaviour.
| df = df.Define( | ||
| "JetTagSel", | ||
| "Jet_p4[Jet_NoOverlapWithMuons && Jet_btag_Veto_medium].size() < 1 && Jet_p4[Jet_NoOverlapWithMuons && Jet_btag_Veto_loose].size() < 2 && No_Jets_in_dead_Zone", | ||
| "Jet_p4[Jet_NoOverlapWithMuons && Jet_btag_Veto_medium].size() < 1 && Jet_p4[Jet_NoOverlapWithMuons && Jet_btag_Veto_loose].size() < 2 ", # && No_Jets_in_dead_Zone", |
Collaborator
There was a problem hiding this comment.
Why do you remove the dead zone veto?
…omCentralNano_bugFixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to apply bug fixes during the first anaTuple production from the Central NanoAOD. Some of them were indeed not tested (as all DY samples etc) that is the reason of the existence of this PR.