Backport of final DQM plot updates for Totem T2 run 25.6 (PR #41922)

[oljemark]

PR description:

For the TOTEM special foreseen on 25.6.2023, the new T2 telescope will be used (and removed after the run) to measure inelastic rate and veto diffractive p+p collisions, when measuring the elastic p+p cross section.
This PR is for a special TOTEM release to be ready for testing start of next week (#41859 (comment)), which is now this week.

This PR backports the DQM fixes in PR #41922 , and rebases that branch on top of the PR #41916, that backports recent TOTEM T2 code development into 13_0_X. This PR is the final one needed for testing a special 13_0_X release for TOTEM, or possibly to be backported to 13_1_X too, see #41916 (comment) . The PR being backported here hasn't yet had testing start, so if any problems should be found, their solution will be added here too.

PR validation:

The code compiles & running the totemt2_dqm_test_common_cfg.py test file gives the expected histograms out, as does the T2 unit test from PR #41916 .

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR proposes to backport PR #41922 to 13_0_X for a special TOTEM release, or testing such, and also maybe to 13_1_X, see discussion above.

[cmsbuild]

A new Pull Request was created by @oljemark for CMSSW_13_0_X.

It involves the following packages:

• CalibPPS/ESProducers (alca)
• CondFormats/PPSObjects (alca)
• DQM/CTPPS (dqm)
• DataFormats/TotemReco (reconstruction)
• EventFilter/CTPPSRawToDigi (reconstruction)
• RecoPPS/Configuration (reconstruction)
• RecoPPS/Local (reconstruction)

@micsucmed, @nothingface0, @emanueleusai, @clacaputo, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @rovere, @Martin-Grunewald, @missirol, @tocheng, @grzanka, @mmusich, @forthommel, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Final DQM plot updates for the Totem T2 in the special run 25.6, to be ready for special TOTEM release testing around 12-13.6 #41922

[mandrenguyen]

type ctpps

[mandrenguyen]

backport of #41922

[mandrenguyen]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5f1ac/33093/summary.html
COMMIT: 9f2ad3d
CMSSW: CMSSW_13_0_X_2023-06-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41923/33093/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 250200.17DAS Error
• 250202.17DAS Error
• 250202.171DAS Error

Expand to see more relval errors ...

• 250202.172
• 250202.18
• 250202.181
• 250202.184

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3315916
• DQMHistoTests: Total failures: 114
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3315780
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[oljemark]

Hi @mandrenguyen & everyone. These DAS errors don't seem to be caused by our code?

[perrotta]

urgent
(DAS input errors are unrelated)

[rappoccio]

This PR will need a "backport" to https://github.com/cms-sw/cmssw/tree/CMSSW_13_0_7_TOTEM_X before we create the release.

[mandrenguyen]

+reconstruction
Indeed DAS errors are unrelated
@oljemark do you think you or someone else can present the a summary of the developments for the high beta* run at the reco meeting this Friday at 15:30 CEST ?

[tvami]

hi @perrotta @rappoccio I'm confused by the last 20 min of activity by you two: Andrea marks this urgent and then Sal says that the PR will actually go to another branch. So then the PR to this branch is not even the important one? Or you plan to merge this PR in both branches? Please clarify, thanks!

[oljemark]

Hi, @perrotta . That was because I wasn't sure if this PR & #41916 could be automerged or if this PR would even compiled if I rebased both on top of 13_0_X, since this PR depends on the T2 code in PR #41916. If you think I can rebase both on top of CMSSW_13_0_7_TOTEM_X, then I'll do that.

[perrotta]

please abort

[perrotta]

please test for CMSSW_13_0_7

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5f1ac/33102/summary.html
COMMIT: 49d15f3
CMSSW: CMSSW_13_0_7/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41923/33102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 232 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3315916
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3315888
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• tests pass

[emanueleusai]

+1

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_7_TOTEM_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1