Removal of LST *ByLayer( functions to fix build errors

[VourMa]

This PR aims to solve the build errors related to LST that were reported in #45117 (comment). The offending functions are not currently in use, so they are removed with this PR, solving the issue.

FYI: @smuzaffar

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46802/42802

[cmsbuild]

A new Pull Request was created by @VourMa for master.

It involves the following packages:

• RecoTracker/LSTCore (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22bc2c/43091/summary.html
COMMIT: 859e555
CMSSW: CMSSW_15_0_X_2024-11-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46802/43091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 286 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3596288
• DQMHistoTests: Total failures: 2469
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593799
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 206 log files, 177 edm output root files, 47 DQM output files
• TriggerResults: found differences in 1 / 45 workflows

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[smuzaffar]

thanks @VourMa , this has fixed the gcc13 build errors. Can you also please provide a fix for the following warning . It looks like shiftedRt2 is not set in some branch of code

  src/RecoTracker/LSTCore/src/alpaka/MiniDoublet.h:497:55: warning: 'shiftedRt2' may be used uninitialized [-Wmaybe-uninitialized]
   497 |         dPhiChange = (shiftedRt2 < rtUpper * rtUpper) ? deltaPhiChange(acc, shiftedX, shiftedY, xUpper, yUpper)
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  498 |                                                       : deltaPhiChange(acc, xUpper, yUpper, shiftedX, shiftedY);
      |                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/RecoTracker/LSTCore/src/alpaka/MiniDoublet.h: In member function 'void alpaka::TaskKernelCpuSerial<TDim, TIdx, TKernelFnObj, TArgs>::operator()() const [with TDim = std::integral_constant<long unsigned int, 3>; TIdx = unsigned int; TKernelFnObj = alpaka_serial_sync::lst::CreateMiniDoublets; TArgs = {const lst::ModulesSoALayout<>::ConstViewTemplateFreeParams<128, false, true, true>&, const lst::HitsSoALayout<>::ConstViewTemplateFreeParams<128, false, true, true>&, const lst::HitsRangesSoALayout<>::ConstViewTemplateFreeParams<128, false, true, true>&, lst::MiniDoubletsSoALayout<>::ViewTemplateFreeParams<128, false, true, true>&, lst::MiniDoubletsOccupancySoALayout<>::ViewTemplateFreeParams<128, false, true, true>&, const lst::ObjectRangesSoALayout<>::ConstViewTemplateFreeParams<128, false, true, true>&}]':
src/RecoTracker/LSTCore/src/alpaka/MiniDoublet.h:424:11: note: 'shiftedRt2' was declared here
  424 |     float shiftedRt2;