Follow up on using cms::alpakatools deltaPhi functions

[VourMa]

This is a follow up to PR #47208, where I missed moving some of the LST functions to the newly introduced cms::alpakatools deltaPhi functions. This PR takes care of those.

The code has been tested locally: it compiles and gives the identical results (on CPU) for LST.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47405/43795

[cmsbuild]

A new Pull Request was created by @VourMa for master.

It involves the following packages:

• RecoTracker/LSTCore (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[slava77]

test parameters:

• enable_tests = gpu
• workflows_gpu = 29634.704,29834.704
• workflows = 29634.703,29834.703
• relvals_opt = -w upgrade,standard
• relvals_opt_gpu = -w upgrade,standard

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771dc2/44520/summary.html
COMMIT: aa40afe
CMSSW: CMSSW_15_1_X_2025-02-19-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47405/44520/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 21 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4212396
• DQMHistoTests: Total failures: 283
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4212093
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 230 log files, 200 edm output root files, 53 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 217 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 117389
• DQMHistoTests: Total failures: 7205
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 110184
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 32 log files, 36 edm output root files, 9 DQM output files
• TriggerResults: no differences found

[jfernan2]

assign heterogeneous

[jfernan2]

+1

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fwyzard]

+heterogeneous

[fwyzard]

enable gpu

[fwyzard]

(sorry, I missed that the test had already been run!)

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771dc2/44535/summary.html
COMMIT: aa40afe
CMSSW: CMSSW_15_1_X_2025-02-19-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47405/44535/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 578 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4212708
• DQMHistoTests: Total failures: 2713
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4209975
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 230 log files, 200 edm output root files, 53 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 232 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 117389
• DQMHistoTests: Total failures: 7290
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 110099
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 32 log files, 36 edm output root files, 9 DQM output files
• TriggerResults: no differences found

[antoniovilela]

+1