Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: attempt to import images from the host #501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

squidboylan
Copy link
Contributor

This is an attempt to address #402 . Throwing this up here to get thoughts on this approach, there's still more work to do including supporting package customization and tests. I considered using https://github.com/kubernetes-sigs/kind/blob/10e058c534cf6b8546be70f1eea2e414a08ff770/pkg/cluster/nodeutils/util.go#L80 like described in the issue but that seems to require a lot more code that is already implemented in kind, and this was the easiest way i could think of reusing that kind code. I admit calling the kind cobra command directly feels like a bit of a hack but at least it's likely to be stable? This also doesnt get us all the way to fixing #415 because it doesnt support images referenced by digest because of kubernetes-sigs/kind#2394 .

@nabuskey
Copy link
Collaborator

Hmmm I wonder if we should use kind load or let another cache program do this for us. @punkwalker What do you think?

@cmoulliard
Copy link
Contributor

Hmmm I wonder if we should use kind load

As mentioned by Cale, kind load do a lot of things under the hood to upload a tarball of an image as it must access the kindnet container to execute some internal commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants