feat: remove STUN/ICE server config, replaced by Iroh transport#556
Closed
feat: remove STUN/ICE server config, replaced by Iroh transport#556
Conversation
Removes all hardcoded STUN server lists, ICE server management UI, and related configuration. ICE candidates are now provided by the AD4M executor via ad4mClient.runtime.iceCandidates() using addresses discovered by the Iroh transport layer. - Remove Connection settings tab from call settings modal - Remove defaultIceServers from constants and webrtcStore - Remove getDefaultIceServers utility - Remove 250+ public STUN server lists from debug/view packages - Remove ICE server add/remove/reset UI and store methods - Update CallWindow beta notice to reference Iroh transport - Pass empty iceServers to WebRTCManager and SfuManager Part of: coasys/ad4m#719
❌ Deploy Preview for fluxsocial-dev failed. Why did it fail? →
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Closing to restart with spec-driven approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all hardcoded STUN server configuration, ICE server management UI, and related handling from Flux. ICE candidates are now provided by the AD4M executor via
ad4mClient.runtime.iceCandidates()using addresses discovered by the Iroh transport layer.Changes
Connection.vuesettings tab (sole purpose was STUN server management)getDefaultIceServers.tsutilitystun-servers.tsfiles containing 250+ public STUN server URLsdefaultIceServersarrays from constants and webrtcStoreIceServertype,addIceServer,removeIceServer,resetIceServersfrom storereact-web/useWebrtc.tsWebRTCManagerto pass emptyiceServers: [](Iroh provides candidates)754 lines removed, 6 added.
Dependencies
Requires the AD4M
runtimeIceCandidatesGraphQL API:See: coasys/ad4m#719