feat: expose local_socket_addrs via HcP2p trait for WebRTC ICE#1
Closed
HexaField wants to merge 1 commit into0.6.0-coasysfrom
Closed
feat: expose local_socket_addrs via HcP2p trait for WebRTC ICE#1HexaField wants to merge 1 commit into0.6.0-coasysfrom
HexaField wants to merge 1 commit into0.6.0-coasysfrom
Conversation
HexaField
force-pushed
the
feat/expose-iroh-endpoint
branch
from
8217ae0 to
f5734ce
Compare
Adds local_socket_addrs() to HcP2p trait with default empty vec. HolochainP2pActor implements it by calling through kitsune.transport().local_socket_addrs(). Enables kitsune2 path overrides for local development with transport changes. Consumers (e.g. AD4M executor) can call conductor.holochain_p2p().local_socket_addrs().await Part of: coasys/ad4m#719
HexaField
force-pushed
the
feat/expose-iroh-endpoint
branch
from
f5734ce to
74c518f
Compare
Author
|
Closing to restart with spec-driven approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces
local_socket_addrs()from the kitsune2 transport layer through theHcP2ptrait, enabling in-process consumers (e.g. AD4M executor) to retrieve transport-discovered socket addresses for WebRTC ICE candidate extraction.Changes
HcP2ptrait: Addedlocal_socket_addrs()with default returning empty vecHolochainP2pActor: Implements by callingkitsune.transport().local_socket_addrs()Cargo.toml: Enabled kitsune2 path overrides for local development with transport changesUsage
Dependencies
Requires holochain/kitsune2#476 for the
local_socket_addrs()addition to theTransporttrait.See: coasys/ad4m#719