Conversation
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughReplaced inline config defaulting with Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@internal/scheduling/reservations/commitments/syncer.go`:
- Around line 55-56: The field syncInterval can remain zero if Init() isn't
called, causing misleading logs in SyncReservations(); fix by initializing
syncInterval in NewSyncer() to the default interval used by the runner (or a
module-level default constant) so it has a non-zero value even before Init(),
update NewSyncer() to set s.syncInterval = defaultSyncInterval (or the runner's
default) and leave Init() to overwrite it when configured; alternatively, if you
prefer conditional logging, change the log code in SyncReservations()/method
that logs syncInterval to print "not configured" when s.syncInterval == 0
instead of the numeric zero.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ebf6edf9-388e-41ac-9437-1b6037ac9a01
📒 Files selected for processing (3)
cmd/main.gointernal/scheduling/reservations/commitments/config.gointernal/scheduling/reservations/commitments/syncer.go
PhilippMatthes
approved these changes
Mar 26, 2026
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal/scheduling/reservations/commitments/syncer.go (1)
55-56: Remove unusedsyncIntervalstate fromSyncer.After Line 206 stopped logging the interval,
syncIntervalis written (Line 68) but never read. Keeping it adds misleading internal state.♻️ Proposed cleanup
type Syncer struct { // Client to fetch commitments from Limes CommitmentsClient // Kubernetes client for CRD operations client.Client // Monitor for metrics monitor *SyncerMonitor - // SyncInterval is stored for logging purposes (actual interval managed by task.Runner) - syncInterval time.Duration } func (s *Syncer) Init(ctx context.Context, config SyncerConfig) error { - s.syncInterval = config.SyncInterval if err := s.CommitmentsClient.Init(ctx, s.Client, config); err != nil { return err } return nil }Also applies to: 68-68
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@internal/scheduling/reservations/commitments/syncer.go` around lines 55 - 56, Remove the unused syncInterval state from the Syncer struct: delete the syncInterval field declaration and remove any places that set or assign Syncer.syncInterval (e.g., in the Syncer constructor/initialization code where it's written). Ensure no code expects or reads syncInterval (update or delete related comments/log statements) so the struct no longer carries misleading unused state; keep other Syncer members and behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@internal/scheduling/reservations/commitments/syncer.go`:
- Around line 55-56: Remove the unused syncInterval state from the Syncer
struct: delete the syncInterval field declaration and remove any places that set
or assign Syncer.syncInterval (e.g., in the Syncer constructor/initialization
code where it's written). Ensure no code expects or reads syncInterval (update
or delete related comments/log statements) so the struct no longer carries
misleading unused state; keep other Syncer members and behavior unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dcc0e769-cecf-4247-b517-3a64a8b0745e
📒 Files selected for processing (1)
internal/scheduling/reservations/commitments/syncer.go
Contributor
Test Coverage ReportTest Coverage 📊: 68.1% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.