image-create: rewrite using test.thing #8238
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
allisonkarlitskaya
force-pushed
the
image-create-tt
branch
3 times, most recently
from
e0b98a3 to
55cf670
Compare
lib/testthing.py
Outdated
| if self._ssh_control_task is not None: | ||
| task = self._ssh_control_task | ||
| task.cancel() | ||
| await task # Cancellation is async, so wait |
Check notice
Code scanning / CodeQL
Statement has no effect
Copilot Autofix
AI about 1 month ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
allisonkarlitskaya
force-pushed
the
image-create-tt
branch
2 times, most recently
from
be9f74a to
fe343d3
Compare
cockpituous
changed the title
cockpituous
changed the title
cockpituous
changed the title
|
image-refresh arch done: https://github.com/cockpit-project/bots/commits/image-refresh-arch-20250913-143503 |
cockpituous
changed the title
|
So just for the record:
Next job will be adding a tonne of cloud-init hacks for the various distros that need them. If we plan to |
Drop the --no-save, --upload, and --store arguments. Nobody uses those: image-refresh calls image-upload for itself.
This benefits from the fact that test.thing is async: instead of the very non-DRY parallel pattern for booting machines, waiting on them, etc. we can just do everything in a single simple async function and use asyncio.gather() to run both instances at once.
This is mostly boring. There is really only one nice cleanup enabled by everything being async: instead of repeating `timeout=1800` everywhere, we can just apply it at the toplevel with a single asyncio.wait_for() invocation. Even though it's not a rewrite, apply a bit of `ruff format` here.
allisonkarlitskaya
force-pushed
the
image-create-tt
branch
from
7eadcd0 to
545fd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the --no-save, --upload, and --store arguments: nobody uses those, right?