jobs/metricspoller: zero out metrics on exit #158335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Typically only the node actively running the poller is expected to export non-zero values for poller-maintained metrics; if a node is not *actively* running the poller it should export zeros, not stale values last set when it was last running it. This change adds on-exit calls to each of the tasks in the poller to let them zero out the metrics they each are responsible for updating when running. Release note: none. Epic: none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically only the node actively running the poller is expected to export non-zero values for poller-maintained metrics; if a node is not actively running the poller it should export zeros, not stale values last set when it was last running it.
This change adds on-exit calls to each of the tasks in the poller to let them zero out the metrics they each are responsible for updating when running.
Release note: none.
Epic: none.