crosscluster/logical: add CPU pacing to batch handling #158361
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
jeffswenson
approved these changes
Nov 25, 2025
Collaborator
|
This should probably respect the logical_replication.consumer.low_admission_priority.enabled setting. |
Contributor
Author
It does, doesn't it? |
Collaborator
|
Ahh. You are right. For some reason I thought useLowPriority was a constant, not the setting. |
Release note (performance improvement): More of the CPU usage of LDR jobs is subject to background job admission control limits. Epic: none.
Contributor
Author
|
TFTR! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (performance improvement): More of the CPU usage of LDR jobs is subject to background job admission control limits.
Epic: none.