-
Notifications
You must be signed in to change notification settings - Fork 475
Link 'Enable super region' to something useful #20523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small observation, just a detail to consider.
So this change makes it so that the link takes you to the "Enable Super Regions" section of the Alter Database page.
When linking from this page (https://www.cockroachlabs.com/docs/v24.1/multiregion-overview) that seems like a good thing.
When linking from this page, though (https://www.cockroachlabs.com/docs/v24.1/show-super-regions) maybe that's not ideal, because there's actually an "Enable Super Regions" heading on this page itself, and maybe the more intuitive link is to the occurrence of that "Enable Super Regions" section on this same page.
Or maybe it doesn't matter.
I'm being very very nitpicky here but it's something to consider.
Updated link with conditional logic based on page
Ah good point, thanks! I have changed the text slightly so it uses Jekyll's templating language Liquid to conditionally link to the anchor on the 'SHOW SUPER REGIONS' page, otherwise link to the one on the ALTER DATABASE page if you haven't used this before, i wrote up a little internal wiki page on it here please take a look and let me know what you think! |
Fixes DOC-12942