feat: collector automatically merge and align multiple collect() called with different schema #1153
+185
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalwaghe-56
force-pushed
the
fix-issue-428
branch
from
77d959d to
fa29eac
Compare
georgeh0
reviewed
Oct 7, 2025
skalwaghe-56
force-pushed
the
fix-issue-428
branch
2 times, most recently
from
c1c43fc to
531b594
Compare
georgeh0
reviewed
Oct 21, 2025
Member
georgeh0
left a comment
georgeh0
left a comment
There was a problem hiding this comment.
Hi @skalwaghe-56, sorry for the late reply! I missed it somehow.
skalwaghe-56
force-pushed
the
fix-issue-428
branch
2 times, most recently
from
d150498 to
86e0c4e
Compare
georgeh0
reviewed
Nov 3, 2025
skalwaghe-56
force-pushed
the
fix-issue-428
branch
from
86e0c4e to
e32309d
Compare
skalwaghe-56
force-pushed
the
fix-issue-428
branch
from
e32309d to
59d9502
Compare
Contributor
Author
|
@georgeh0 Please check now and get this merged. Thanks! |
georgeh0
reviewed
Nov 5, 2025
…ed with different schema
skalwaghe-56
force-pushed
the
fix-issue-428
branch
from
59d9502 to
69b6de3
Compare
georgeh0
approved these changes
Nov 7, 2025
Member
|
Thanks a lot for the PR! This is a huge work! |
Member
|
thanks @skalwaghe-56 this is amazing!! |
Contributor
Author
|
@georgeh0 @badmonster0 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented automatic schema merging for collectors that:
Closes #428.