Skip to content

fix crash when create too many spine animations at a time cause a cra… #20683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from
Open

fix crash when create too many spine animations at a time cause a cra… #20683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d493654
fix crash when create too many spine animations at a time cause a cra…
Naibasak Aug 11, 2021
4a249ec
Update SkeletonBatch.cpp
Naibasak Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cocos/editor-support/spine/v4/SkeletonBatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ USING_NS_CC;
#define EVENT_AFTER_DRAW_RESET_POSITION "director_after_draw"
using std::max;
#define INITIAL_SIZE (10000)
#define VETEXT_BUFF_SIZE (64000)

#include "renderer/ccShaders.h"
#include "renderer/backend/Device.h"
Expand Down Expand Up @@ -103,6 +104,17 @@ void SkeletonBatch::update (float delta) {

cocos2d::V3F_C4B_T2F* SkeletonBatch::allocateVertices(uint32_t numVertices) {
if (_vertices.size() - _numVertices < numVertices) {
//Creating a large number of different spine animations at the same time
//results in the allocation of vertex vector(large than 1.4 billion)
//Then run out of memory and crash.
if (_vertices.size() > VETEXT_BUFF_SIZE)
{
//CCLOG("SkeletonBatch::allocateVertices _vertices size:%d, clear here...", _vertices.size());
reset();
_vertices.resize(VETEXT_BUFF_SIZE);
}
//CCLOG("SkeletonBatch::allocateVertices _vertices vector size:%d, _numVertices:%d, add vertics:%d", _vertices.size(), _numVertices, numVertices);

cocos2d::V3F_C4B_T2F* oldData = _vertices.data();
_vertices.resize((_vertices.size() + numVertices) * 2 + 1);
cocos2d::V3F_C4B_T2F* newData = _vertices.data();
Expand Down