문의 이미지 미반영 및 multipart 인터셉터 버그 수정#446
Conversation
└ S3 업로드 후 쿼리 재무효화, 토큰 갱신 재시도 인스턴스 수정, 후기 작성 기간 7일 제한 적용 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough다중부분 업로드 타임아웃을 10초에서 60초로 늘리고, 토큰 갱신 후 재시도에서 multipart 전용 axios 인스턴스를 사용하도록 수정했습니다. 리뷰 페이지에 종료일 기준 7일 검토 기간 검증을 추가하고, 글로벌 유틸리티 CSS와 모달·이미지 업로드 관련 UI·캐시 무효화 로직을 조정했습니다. Changes
Sequence Diagram(s)(생성 조건에 해당하지 않아 생략) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/app/`(service)/(my)/my-study-review/_components/completed-study-review-page.tsx:
- Around line 168-170: The early return in the completed review flow (the
isWithinReviewPeriod(study.endTime) check) silently stops rendering and should
instead show a user-facing toast; update the branch in the component that calls
isWithinReviewPeriod to invoke the toast API (useToastStore) with a clear
message about reviews being outside the allowed period before returning,
matching other branches' behavior (i.e., call useToastStore().show or the
project’s toast method with a descriptive title/body and appropriate intent) so
users see why the action was blocked.
In `@src/components/common/ui/image-upload-input.tsx`:
- Around line 161-163: The JSX renders sizeError with a non-existent CSS token
class "text-text-danger"; update the class to use the correct semantic token
class (e.g., "text-text-error") or apply the CSS variable --color-text-error
(via your existing token-based class) so the error text uses the defined token;
locate the JSX that outputs sizeError (the <p> rendering of sizeError) and
replace "text-text-danger" with the correct token-based class name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5a792ee7-ed97-443e-aead-30da0d4b9c30
📒 Files selected for processing (5)
src/api/client/axios.tssrc/app/(service)/(my)/my-study-review/_components/completed-study-review-page.tsxsrc/app/global.csssrc/components/common/modals/question-modal.tsxsrc/components/common/ui/image-upload-input.tsx
Summary
min-h-150,max-w-500,size-icon)Changes
Bug Fixes
src/components/common/modals/question-modal.tsxinvalidateQueries재호출하여 이미지 포함 최신 데이터 로드src/api/client/axios.tsaxiosInstance→axiosInstanceForMultipart(2곳), timeout 10s → 60ssrc/app/(service)/(my)/my-study-review/_components/completed-study-review-page.tsxisWithinReviewPeriod()추가 — 종료 후 7일 초과 시 후기 작성 차단Style
src/app/global.css@utility min-h-150,max-w-500,size-icon토큰 추가src/components/common/ui/image-upload-input.tsxborder-gray-300→border-border-default, 파일 크기 힌트 텍스트 추가, 임의값 제거Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
릴리스 노트
새로운 기능
버그 수정
개선사항