멘토스터디 / 그룹스터디 미션 평가 노출 로직 수정 및 JS 로드 크기 개선#541
Merged
Conversation
- 마크다운 에디터 적용 후 커졌던 First Load JS 크기를 dynamic import 방식을 적용하여 약 36% 개선
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough과제 평가 모달(CreateEvaluationModal) 추가, HomeworkDetailContent에 리더 평가 섹션 연동, 클라이언트 전용 동적 로드(ssr: false)로 변경, 미션/홈워크 카드의 클릭·마크업 및 제출 상태 메시지 분리, 미션 상세의 진행 계산 보정이 적용되었습니다. Changes
Sequence DiagramsequenceDiagram
actor User
participant Modal as CreateEvaluationModal
participant Grades as useGetMissionEvaluationGrades()
participant Form as CreateEvaluationForm
participant API as useCreateEvaluation()
participant Server as Backend
participant Toast as Toast
User->>Modal: "과제 평가하기" 클릭
Modal->>Grades: 등급 목록 요청
Grades-->>Modal: 등급 목록 응답
User->>Form: 등급 선택 및 코멘트 입력
Form->>Form: Zod 유효성 검사
User->>Modal: "평가 완료" 클릭 (form 제출)
Modal->>API: mutate(homeworkId, {gradeCode, comment})
API->>Server: POST /evaluations
Server-->>API: 성공 응답
API-->>Modal: 성공
Modal->>Toast: 성공 토스트 표시
Modal->>Modal: 모달 닫기
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22분 Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/card/my-homework-status-card.tsx (1)
37-55:⚠️ Potential issue | 🟠 Major미션 상태 분기 누락으로 미제출 안내 문구가 비어 보일 수 있습니다.
mission.status가EVALUATION_COMPLETED인 경우(Line 37-38) 현재 세 조건이 모두false가 되어(Line 48, Line 51, Line 54) 상태 안내가 전혀 렌더링되지 않습니다. 미제출 사용자에게 빈 상태 카드가 노출됩니다. 상태-문구를 단일 매핑으로 통합하고 기본(fallback) 문구를 두는 방식으로 분기 누락을 막아주세요.💡 제안 수정안
- const isSubmissionOpen = mission?.status === 'IN_PROGRESS'; - const isSubmissionNotOpened = mission?.status === 'NOT_STARTED'; - const isSubmissionEnded = mission?.status === 'ENDED'; + const isSubmissionOpen = mission?.status === 'IN_PROGRESS'; + const submissionMessageByStatus: Record<string, string> = { + IN_PROGRESS: '아직 과제를 제출하지 않았습니다.', + NOT_STARTED: '과제 제출 기간이 아닙니다.', + ENDED: '제출 기간이 종료되었습니다.', + EVALUATION_COMPLETED: '제출 기간이 종료되었습니다.', + }; + const submissionMessage = + (mission?.status && submissionMessageByStatus[mission.status]) ?? + '과제 상태를 확인할 수 없습니다.'; @@ - <span className="text-text-subtlest font-designer-14r"> - {isSubmissionOpen && '아직 과제를 제출하지 않았습니다.'} - </span> - <span className="text-text-subtlest font-designer-14r"> - {isSubmissionNotOpened && '과제 제출 기간이 아닙니다.'} - </span> - <span className="text-text-subtlest font-designer-14r"> - {isSubmissionEnded && '제출 기간이 종료되었습니다.'} - </span> + <span className="text-text-subtlest font-designer-14r"> + {submissionMessage} + </span>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/card/my-homework-status-card.tsx` around lines 37 - 55, The card currently computes booleans (isSubmissionNotOpened, isSubmissionEnded, and isSubmissionOpen) and then renders three separate conditional spans which all stay false for mission.status === 'EVALUATION_COMPLETED', leaving an empty card; replace these separate conditionals in the NOT_SUBMITTED branch with a single status-to-message mapping (e.g., a map keyed by mission.status) and render the mapped message or a default fallback string when no key matches; update references to mission.status and the booleans (isSubmissionNotOpened, isSubmissionEnded, isSubmissionOpen) in the render path to use the map lookup so the NOT_SUBMITTED UI always shows a message.
🧹 Nitpick comments (2)
src/components/section/premium-study-info-section.tsx (1)
11-11: 주석 처리된 import를 제거하세요.사용하지 않는 주석 처리된 import가 남아있습니다. 동적 import로 대체되었으므로 이 줄을 삭제해주세요.
🧹 제안된 수정
-// import MarkdownContent from '@/components/common/ui/editor/markdown-content';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/section/premium-study-info-section.tsx` at line 11, 주석 처리된 사용하지 않는 import 문을 제거하세요: 파일의 "// import MarkdownContent from '@/components/common/ui/editor/markdown-content';" 라인을 삭제하여 정리하고, 컴포넌트 내에서 이미 동적 import로 로드되는 MarkdownContent 참조(또는 관련 동적 import 호출)를 유지해 중복 import 주석을 남기지 않도록 하세요.src/components/section/group-study-info-section.tsx (1)
13-13: 주석 처리된 import를 제거하세요.
premium-study-info-section.tsx와 동일하게, 사용하지 않는 주석 처리된 import를 삭제해주세요.🧹 제안된 수정
-// import MarkdownContent from '@/components/common/ui/editor/markdown-content';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/section/group-study-info-section.tsx` at line 13, 파일 src/components/section/group-study-info-section.tsx에 남아있는 주석 처리된 import 문을 제거하세요; 구체적으로 "// import MarkdownContent from '@/components/common/ui/editor/markdown-content';" 라인(참조 심볼: MarkdownContent)을 삭제하여 premium-study-info-section.tsx와 동일하게 사용하지 않는 주석된 import를 정리합니다.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/common/modals/create-evaluation-modal.tsx`:
- Around line 112-117: gradeOptions can become undefined while
useGetMissionEvaluationGrades() is still loading, causing downstream consumers
like GroupItems to receive undefined; change the expression that builds
gradeOptions (currently referencing grades and mapping into value/label) to
safely handle missing data by using a fallback empty array (e.g., operate on
(grades ?? []) or default to []) so gradeOptions is always an array, preserving
the same sort/map logic and label formatting, and ensure GroupItems is passed
this guaranteed-array gradeOptions.
In `@src/components/contents/homework-detail-content.tsx`:
- Around line 160-165: Change the mission-status check that controls rendering
of the leader evaluation UI: in the conditional using showLeaderEvaluation and
mission.status (which currently compares to 'EVALUATION_COMPLETED'), update it
to check for 'ENDED' instead so LeaderEvaluationSection (which passes evaluation
and homeworkId and allows CreateEvaluationModal when !evaluation) only renders
after submission deadline; ensure the condition reads mission.status === 'ENDED'
alongside the existing showLeaderEvaluation guard.
In `@src/components/section/mission-section.tsx`:
- Around line 176-179: The bug is that canAccessAll can be boolean | undefined
(since isMember and isLeaderProp are optional), causing showMyHomework !== false
to evaluate true for undefined and incorrectly show "내 과제 현황"; fix by making
canAccessAll an explicit boolean or changing the component check: either coerce
the value where it’s computed using canAccessAll = !!(isMember || isLeaderProp)
so MissionDetailContent always receives a boolean, or keep the prop but update
MissionDetailContent to only show homework when showMyHomework === true (change
the conditional that checks showMyHomework to a strict equality).
---
Outside diff comments:
In `@src/components/card/my-homework-status-card.tsx`:
- Around line 37-55: The card currently computes booleans
(isSubmissionNotOpened, isSubmissionEnded, and isSubmissionOpen) and then
renders three separate conditional spans which all stay false for mission.status
=== 'EVALUATION_COMPLETED', leaving an empty card; replace these separate
conditionals in the NOT_SUBMITTED branch with a single status-to-message mapping
(e.g., a map keyed by mission.status) and render the mapped message or a default
fallback string when no key matches; update references to mission.status and the
booleans (isSubmissionNotOpened, isSubmissionEnded, isSubmissionOpen) in the
render path to use the map lookup so the NOT_SUBMITTED UI always shows a
message.
---
Nitpick comments:
In `@src/components/section/group-study-info-section.tsx`:
- Line 13: 파일 src/components/section/group-study-info-section.tsx에 남아있는 주석 처리된
import 문을 제거하세요; 구체적으로 "// import MarkdownContent from
'@/components/common/ui/editor/markdown-content';" 라인(참조 심볼: MarkdownContent)을
삭제하여 premium-study-info-section.tsx와 동일하게 사용하지 않는 주석된 import를 정리합니다.
In `@src/components/section/premium-study-info-section.tsx`:
- Line 11: 주석 처리된 사용하지 않는 import 문을 제거하세요: 파일의 "// import MarkdownContent from
'@/components/common/ui/editor/markdown-content';" 라인을 삭제하여 정리하고, 컴포넌트 내에서 이미 동적
import로 로드되는 MarkdownContent 참조(또는 관련 동적 import 호출)를 유지해 중복 import 주석을 남기지 않도록
하세요.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 48c8563f-c893-42f8-8ecb-e78c34cf7b45
📒 Files selected for processing (7)
src/components/card/mission-card.tsxsrc/components/card/my-homework-status-card.tsxsrc/components/common/modals/create-evaluation-modal.tsxsrc/components/contents/homework-detail-content.tsxsrc/components/section/group-study-info-section.tsxsrc/components/section/mission-section.tsxsrc/components/section/premium-study-info-section.tsx
"EVALUATION_COMPLETED" 에서 "ENDED"로 수정
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/contents/homework-detail-content.tsx`:
- Around line 465-467: The paragraph currently renders evaluation.comment
directly which leaves the UI empty when evaluation.comment is undefined or an
empty string; update the render in the HomeworkDetailContent component so the
<p> that references evaluation.comment uses an explicit fallback (same style as
the grade fallback) — e.g. replace direct use of evaluation.comment with a check
for null/empty and render a default string like "평가 없음" or the existing grade
fallback value instead; ensure the element and its classes (the <p> with
className "text-text-default font-designer-14r wrap-anywhere
whitespace-pre-wrap") still preserve whitespace formatting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cd6ba456-ef3b-474e-8293-f73b038000c2
📒 Files selected for processing (2)
src/components/card/my-homework-status-card.tsxsrc/components/contents/homework-detail-content.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/card/my-homework-status-card.tsx
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/time.ts`:
- Around line 124-127: Fix camelCase typos by renaming existingmissionStartDate
and existingmissionEndDate to existingMissionStartDate and
existingMissionEndDate, and make toDateOnly robust for KST/ISO date strings by
importing parseISO and isValid from date-fns, using parseISO when the input is a
string (fallback to new Date for Date inputs), validate with isValid, then zero
out time via setHours(0,0,0,0); ensure callers handle parse failures
appropriately (throw or return null) and update any references to the renamed
variables (e.g., existingMissionStartDate, existingMissionEndDate) and the
toDateOnly function signature accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0a316cc4-91eb-4237-98e3-952559d9e141
📒 Files selected for processing (1)
src/utils/time.ts
Comment on lines
+124
to
+127
| const toDateOnly = (date: Date | string): Date => { | ||
| const d = new Date(date); | ||
| d.setHours(0, 0, 0, 0); | ||
| return d; |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
JavaScript에서 new Date('YYYY-MM-DD')는 UTC로 파싱되나요? date-fns의 parseISO('YYYY-MM-DD')와 타임존 동작 차이를 공식 문서 기준으로 비교해 주세요.
💡 Result:
결론: new Date('YYYY-MM-DD')는 UTC 기준으로(자정 UTC) 파싱됩니다. 반면 date-fns의 parseISO('YYYY-MM-DD')는 로컬 타임존 기준(로컬 자정)으로 결과 Date를 만듭니다.
1) JavaScript new Date('YYYY-MM-DD') (=Date.parse 규칙)
MDN의 “Date time string format” 설명에 따르면:
- 타임존 오프셋이 없는 경우
- date-only 형식(
YYYY-MM-DD)은 UTC로 해석 - date-time 형식(
YYYY-MM-DDTHH:mm:ss)은 로컬 타임존으로 해석
- date-only 형식(
- 그리고 이 동작은 “역사적 스펙 오류(ISO 8601과 불일치)지만 웹 호환성 때문에 유지”라고 명시돼 있습니다. (developer.mozilla.org)
또한 MDN Date.parse() 예시는 date-only 문자열이 UTC를 암시한다고 직접 말합니다. (developer.mozilla.org)
따라서:
new Date('2019-01-01')→ 2019-01-01T00:00:00.000Z (UTC 자정) 로 파싱- 이 값을
toString()(로컬 표시)로 보면, 로컬이 UTC보다 뒤(예: 미국)인 경우 전날 저녁으로 보일 수 있습니다(표시 변환 때문).
2) date-fns parseISO('YYYY-MM-DD')
date-fns의 parseISO 구현(공식 GitHub 소스 코드 JSDoc)에:
@returns The parsed date in the local time zone(로컬 타임존에서의 파싱 결과를 반환) 이라고 명시돼 있습니다. (github.com)
또한 구현 로직상 입력에 timezone이 없으면 UTC 컴포넌트를 꺼내서(getUTC*) 결과 Date에 로컬 시간으로 세팅해 **“로컬 자정의 같은 달력 날짜”**가 되도록 처리합니다. (github.com)
(입력에 Z 또는 +09:00 같은 timezone이 있으면 그 오프셋을 적용해 타임스탬프를 계산합니다. (github.com))
따라서:
parseISO('2019-01-01')→ 로컬 타임존의 2019-01-01 00:00:00 에 해당하는Date
3) 차이 요약 (공식 문서/소스 기준)
| 입력 | new Date(input) / Date.parse(input) |
parseISO(input) |
|---|---|---|
YYYY-MM-DD (date-only) |
UTC로 해석 (developer.mozilla.org) | 로컬 타임존 결과 (github.com) |
YYYY-MM-DDTHH:mm:ss (오프셋 없음) |
로컬로 해석 (developer.mozilla.org) | (timezone 없으면) 로컬 타임존 결과 (github.com) |
...Z / ...+09:00 (오프셋 있음) |
오프셋 반영해 타임스탬프 계산(UTC 기준) (developer.mozilla.org) | 오프셋 파싱 후 타임스탬프 계산 (github.com) |
원하시면, 사용 중인 환경(브라우저/Node, 사용자의 타임존 예: America/New_York)을 기준으로 toString(), toISOString()까지 포함한 “왜 하루가 밀려 보이는지” 재현 코드도 함께 정리해 드릴게요.
Citations:
- 1: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date
- 2: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Date/parse
- 3: https://github.com/date-fns/date-fns/blob/main/src/parseISO/index.ts
- 4: https://github.com/date-fns/date-fns/blob/main/src/parseISO/index.ts
- 5: https://github.com/date-fns/date-fns/blob/main/src/parseISO/index.ts
- 6: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date
- 7: https://github.com/date-fns/date-fns/blob/main/src/parseISO/index.ts
- 8: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Date/parse
- 9: https://github.com/date-fns/date-fns/blob/main/src/parseISO/index.ts
- 10: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date
- 11: https://github.com/date-fns/date-fns/blob/main/src/parseISO/index.ts
🏁 Script executed:
# 1. 파일 전체 내용 확인 (크기 확인 후 읽기)
wc -l src/utils/time.tsRepository: code-zero-to-one/study-platform-client
Length of output: 103
🏁 Script executed:
# 2. 함수 전체 구현 확인
sed -n '100,180p' src/utils/time.tsRepository: code-zero-to-one/study-platform-client
Length of output: 2287
🏁 Script executed:
# 3. getKoreaDate 구현 확인
grep -n "getKoreaDate\|export.*const getKoreaDate" src/utils/time.tsRepository: code-zero-to-one/study-platform-client
Length of output: 503
🏁 Script executed:
# 4. date-fns import 확인
head -30 src/utils/time.ts | grep -E "import.*from.*date-fns"Repository: code-zero-to-one/study-platform-client
Length of output: 119
🏁 Script executed:
# 5. mission 관련 타입 정의 확인 (startDate, endDate 형식)
find src -name "*.ts" -o -name "*.tsx" | xargs grep -l "interface.*Mission\|type.*Mission" | head -5Repository: code-zero-to-one/study-platform-client
Length of output: 329
🏁 Script executed:
# 6. 실제 데이터 흐름: createDisabledDateMatcherForMission 호출 지점 확인
rg "createDisabledDateMatcherForMission" -A 3 -B 3 | head -40Repository: code-zero-to-one/study-platform-client
Length of output: 2981
🏁 Script executed:
# getKoreaDate 상세 구현 확인
sed -n '38,50p' src/utils/time.tsRepository: code-zero-to-one/study-platform-client
Length of output: 473
🏁 Script executed:
# 백엔드 API 응답 타입 확인
cat src/api/openapi/models/mission-list-response-schema.ts | head -50Repository: code-zero-to-one/study-platform-client
Length of output: 827
🏁 Script executed:
# 실제 데이터 흐름: create-mission-modal에서 studyStartDate 출처 확인
grep -n "studyStartDate\|studyEndDate" src/components/common/modals/create-mission-modal.tsx | head -10Repository: code-zero-to-one/study-platform-client
Length of output: 471
🏁 Script executed:
# Mission 상세 타입 확인 - startDate 형식 명시
grep -A 30 "interface.*MissionListResponse\|export.*MissionListResponse" src/api/openapi/models/mission-list-response-schema.ts | head -40Repository: code-zero-to-one/study-platform-client
Length of output: 383
🏁 Script executed:
# Mission 상세 API 모델 확인 - mission-api.ts 에서 date 필드 타입
cat src/api/openapi/models/mission-creation-request.tsRepository: code-zero-to-one/study-platform-client
Length of output: 738
🏁 Script executed:
# useGroupStudyDetailQuery 데이터 형식 확인
rg "useGroupStudyDetailQuery\|basicInfo" -A 5 src/hooks/queries/use-study-query.ts | head -30Repository: code-zero-to-one/study-platform-client
Length of output: 64
🏁 Script executed:
# 실제 백엔드 응답 예시가 있는지 스키마 확인
find src -name "*.ts" | xargs grep -l "startDate.*string\|endDate.*string" | head -5Repository: code-zero-to-one/study-platform-client
Length of output: 313
🏁 Script executed:
# 최종 확인: 백엔드 응답 데이터 형식 추적
# mission 객체가 실제로 어떤 format으로 오는지 테스트 또는 예시 찾기
rg "mission\.(startDate|endDate)" -B 3 -A 3 src/components/common/modals/ | head -50Repository: code-zero-to-one/study-platform-client
Length of output: 64
🏁 Script executed:
# API 문서 또는 타입 정의에서 실제 date format 명시 확인
find src/api/openapi/models -name "*mission*" -type f | xargs grep -l "startDate\|endDate"Repository: code-zero-to-one/study-platform-client
Length of output: 229
🏁 Script executed:
# 전체 파일 최종 검토: 실제 Line 161-162 오타 재확인
sed -n '155,170p' src/utils/time.tsRepository: code-zero-to-one/study-platform-client
Length of output: 646
🏁 Script executed:
# 백엔드 실제 응답 형식 최종 추적: mission-list-response.ts 상세 확인
cat src/api/openapi/models/mission-list-response.ts | head -80Repository: code-zero-to-one/study-platform-client
Length of output: 995
🏁 Script executed:
# study.basicInfo.startDate 실제 타입 추적
find src/api/openapi/models -name "*study*" -o -name "*group*" | xargs cat 2>/dev/null | grep -A 20 "startDate\|endDate" | head -40Repository: code-zero-to-one/study-platform-client
Length of output: 1038
🏁 Script executed:
# 현재 date-fns 라이브러리 버전 확인 (parseISO 사용 가능 여부)
grep "date-fns" package.jsonRepository: code-zero-to-one/study-platform-client
Length of output: 107
Line 161-162의 카멜케이스 오류 수정과 KST 기준 날짜 파싱 일관성 필요.
Line 161-162에서 변수명 existingmissionStartDate, existingmissionEndDate (첫 글자 소문자)이 발견되었습니다. 또한 new Date('YYYY-MM-DD') 형식의 문자열 파싱은 UTC 기준으로 이루어지므로, 비-KST 환경에서 클라이언트 시간으로 렌더링될 때 로컬 날짜가 하루 밀릴 수 있습니다. 함수가 KST 기준 로직을 의도했다면, date-fns의 parseISO 사용이나 명시적 타임존 처리가 필요합니다.
제안 수정안
-const toDateOnly = (date: Date | string): Date => {
- const d = new Date(date);
- d.setHours(0, 0, 0, 0);
- return d;
-};
+const toDateOnly = (input: Date | string): Date => {
+ const source =
+ typeof input === 'string' ? parseISO(input) : new Date(input);
+ if (!isValid(source)) return new Date(NaN);
+ return new Date(
+ source.getFullYear(),
+ source.getMonth(),
+ source.getDate(),
+ );
+};- const existingmissionStartDate = toDateOnly(
- mission.startDate,
- ).getTime();
-
- const existingmissionEndDate = toDateOnly(mission.endDate).getTime();
+ const existingMissionStartDate = toDateOnly(mission.startDate);
+ const existingMissionEndDate = toDateOnly(mission.endDate);
+ if (
+ !isValid(existingMissionStartDate) ||
+ !isValid(existingMissionEndDate)
+ )
+ continue;
if (
- candidateTime >= existingmissionStartDate &&
- candidateTime <= existingmissionEndDate
+ candidateTime >= existingMissionStartDate.getTime() &&
+ candidateTime <= existingMissionEndDate.getTime()
)
return true;parseISO, isValid는 date-fns에서 import 필요합니다.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/utils/time.ts` around lines 124 - 127, Fix camelCase typos by renaming
existingmissionStartDate and existingmissionEndDate to existingMissionStartDate
and existingMissionEndDate, and make toDateOnly robust for KST/ISO date strings
by importing parseISO and isValid from date-fns, using parseISO when the input
is a string (fallback to new Date for Date inputs), validate with isValid, then
zero out time via setHours(0,0,0,0); ensure callers handle parse failures
appropriately (throw or return null) and update any references to the renamed
variables (e.g., existingMissionStartDate, existingMissionEndDate) and the
toDateOnly function signature accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 연관된 이슈
☘️ 작업 내용
🍀 참고사항
스크린샷 (선택)
Summary by CodeRabbit
새로운 기능
UI 개선
리팩터링 / 성능
버그 수정