-
Notifications
You must be signed in to change notification settings - Fork 0
MENTOR_STUDY 참여 여부 필터링 버그 수정 #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type재필터링이 남아 있어 레거시 참여 스터디가 다시 누락될 수 있습니다.studyType는 이미 API 요청에서 전달되고 있으므로, 여기서study.type을 다시 비교하면 레거시 값(MENTORING) 케이스가 제외될 수 있습니다.participatingStudyIds는 응답content전체에서 바로 구성하는 쪽이 안전합니다.수정 제안
Based on learnings: In
code-zero-to-one/study-platform-client, existing DB records includeclassification='GROUP_STUDY'withtype='MENTORING', so strict frontend type re-filtering can exclude valid items.🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
회원의 참여 스터디 조회 요청 시(v2)
이렇게 응답이 내려오고 있어.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HA-SEUNG-JEONG, 공유해 주신 실제 API 응답을 보니 제 코멘트가 잘못되었습니다. 사과드립니다.응답에
type: "ONE_ON_ONE_STUDY"(studyId: 6) 항목이 포함되어 있는 것처럼, V2 API는studyType쿼리 파라미터를 보내도 여러 타입을 혼합하여 반환합니다. 따라서 현재 PR의study.type === studyType재필터링은 정확히 필요한 로직입니다 — 이 필터 없이 전체content를 그대로 사용하면ONE_ON_ONE_STUDYID가participatingStudyIds에 포함되어 하위 필터링에서 잘못된 매칭이 발생할 수 있습니다.현재 구현이 올바릅니다. 제 코멘트를 무시해 주세요.
✏️ Learnings added
🧠 Learnings used