fix(class-lesson): lesson 상세에서 :name: shortcode 치환 누락 보강#660
Merged
Conversation
…e: shortcode를 emoticon 이미지로 치환 - markdown-content-core.tsx에 replaceEmoticonShortcodes 호출 추가 (sanitize 직전) - SANITIZE_OPTIONS ALLOWED_URI_REGEXP에 /emoticon/ prefix 허용 - className에 emoticon size variant 4단 CSS 추가 (24/48/96/150px) - lesson 상세 페이지(/class/[slug]/lesson/[id])는 MarkdownContent가 아닌 MarkdownContentCore를 쓰고 있어 이전 PR #659 적용 범위에서 누락됨 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough마크다운 콘텐츠 렌더링 에서 이모티콘 쇼트코드 처리를 추가합니다. 함수를 import한 후 콘텐츠 변환 파이프라인에 통합하고, 해당 리소스 URL 차단을 해제한 뒤 CSS 스타일링을 적용합니다. Changes이모티콘 쇼트코드 처리 지원
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
MarkdownContentCore(lesson 상세 페이지가 쓰는 컴포넌트)에replaceEmoticonShortcodes호출 추가SANITIZE_OPTIONS.ALLOWED_URI_REGEXP에/emoticon/prefix 허용emoticon-inline / lg / xl / xxl) 추가변경 이유
MarkdownContent(에디터/미리보기용)에만 치환을 추가했음.src/app/(class-lesson)/class/[slug]/lesson/[id]/page.tsx는MarkdownContentCore라는 별도 컴포넌트로 본문을 렌더링하기 때문에, 운영 사이트에서:aha_xxl:같은 토큰이 텍스트 그대로 노출되는 회귀가 발생.emoticon-shortcode.ts)를 공유해 동일하게 풀리도록 보강.dev/QA 검증 evidence
production 영향
/class/{slug}/lesson/{id})와MarkdownContentCore를 쓰는 다른 화면.release contract 영향
검증 방법
https://www.zeroone.it.kr/class/vibe-intro-claude-code/lesson/{1~8}접속 → 각 lesson 본문의:aha_xxl:,:okay_xxl:,:joyful_xxl:,:medallion_xxl:,:expect_xxl:,:hustle_xxl:,:what_xxl:가 150px 캐릭터 이미지로 정상 렌더되는지 확인브랜치 정보
롤백 계획
known risk / not-tested
MarkdownContent와MarkdownContentCore가 별도 컴포넌트로 존재해 같은 정책을 두 군데 유지하는 구조가 됨. 향후 두 컴포넌트 통합 또는 공통 치환 유틸 추출을 검토 권장.🤖 Generated with Claude Code
Summary by CodeRabbit
새로운 기능