feat: make errors spanned in computations #1
+499
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorrenson
reviewed
Nov 26, 2021
| body: Box::new(body), | ||
| }) | ||
| Sym::Lambda(prog) => non_linear_check( | ||
| prog.iter().map(|s| &s.value).positioned( |
There was a problem hiding this comment.
I think we should avoid such "on the fly" computation of default positions and provide another representation of programs that includes position information instead @SolarLiner
There was a problem hiding this comment.
You mean baking positions into ComputationTree? I don't think it is necessary to duplicate data structures here; otherwise yes, keeping positions around would be best.
There was a problem hiding this comment.
Yup. In that case let's just add a field for the positions in the ComputationTree
There was a problem hiding this comment.
We can use the Spanned wrapper type that has all the goodies to make manipulating positions and values easier within it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.