m/p#25
Merged
StanBarrows merged 2 commits intoproductionfrom Jul 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request appears to be a maintenance update with the vague title "m/p". The changes include route cleanup, UI component refactoring, and addition of rounding controls to reporting functionality.
- Removes an unused organization counts route and cleans up TODO comments from delete routes
- Replaces VueUse CSS variable utility with a custom implementation and updates font family from Outfit to Inter
- Adds time entry rounding controls to the reporting overview with configurable rounding types and intervals
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| routes/api.php | Removes unused organization counts route and cleans up TODO comments from project/client delete routes |
| resources/js/Components/Dashboard/ThisWeekOverview.vue | Replaces useCssVar with custom useCssVariable utility and updates font family to Inter |
| resources/js/Components/Common/Reporting/ReportingOverview.vue | Adds rounding controls component with configurable rounding settings and API integration |
| import { useProjectsStore } from '@/utils/useProjects'; | ||
|
|
||
| // TimeEntryRoundingType is now defined in ReportingRoundingControls component | ||
| type TimeEntryRoundingType = 'up' | 'down' | 'nearest'; |
There was a problem hiding this comment.
The TimeEntryRoundingType is defined locally in this component but the comment suggests it's defined in ReportingRoundingControls. This creates duplicate type definitions and potential inconsistencies. Consider importing the type from a shared location or the ReportingRoundingControls component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.