feat: Reorganize tests to use Verify. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cense change. Reorganize Tests
|
I'm not fussy. My first impression is that it's harder to see the "expected" output and the test input at the same time, which I'm habituated to, but as long as it has good test coverage, I'm pretty happy. |
|
Glad to see the test are broken out into separate classes - that's something I've thought about a few times too. |
|
I just did some reading about Verify - I see the beauty of it now. No more fiddly manual config of "expected output" - that is nice! |
|
@simonmckenzie Yes, especially with the Plugins for your IDE, Verify has a really good workflow. Much better than doing it by hand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop FluentAssertions due to license change. Reorganize Tests.
I've also tried out TUnit and while I like it's basic syntax more it has some issues with Rider and Verify, so I kept that out for now
@simonmckenzie Could you give me your opinion?