67 method with a default enum parameter wich type is byte does not compile #70
Conversation
|
It generates better code than my version, and with less code, so I'm all for this approach! |
|
Ok, will get it merge ready |
|
Something I wasn't sure about is what will happen if the enum type is in an external DLL - will the enum variable names still resolve? I'm not entirely sure how much of the externally-referenced code will be present. It'd also be good to see a test with a flags enum and a combined default value, more to understand what it generates than out of any fear it would break. |
| @@ -15,7 +15,8 @@ private static string InheritDoc(ISymbol source) => | |||
| private static readonly SymbolDisplayFormat FullyQualifiedDisplayFormat = | |||
| new( | |||
| genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters, | |||
| memberOptions: SymbolDisplayMemberOptions.IncludeParameters, | |||
| memberOptions: SymbolDisplayMemberOptions.IncludeParameters | |||
| | SymbolDisplayMemberOptions.IncludeContainingType, | |||
There was a problem hiding this comment.
I can't believe this is a member option! 🤦♀️ I didn't even consider that a member option could control default parameter rendering!
There was a problem hiding this comment.
I found that also quite surprising. I played around until it worked ;).
Not ideal, but nothing of that is documented...
ChristianSauer
deleted the
67-method-with-a-default-enum-parameter-wich-type-is-byte-does-not-compile
branch
I worked on this on friday but did not push it.
It conflicts with your idea @simonmckenzie . What is your opinion?
I also suspect some more issues with enums, e.g. usage in params and so on. Will try to to test this out now