-
Notifications
You must be signed in to change notification settings - Fork 20
Fully qualify references to generated interfaces #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simonmckenzie
wants to merge
6
commits into
codecentric:master
Choose a base branch
from
simonmckenzie:feature/fully-qualify-references-to-generated-interfaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fully qualify references to generated interfaces #89
simonmckenzie
wants to merge
6
commits into
codecentric:master
from
simonmckenzie:feature/fully-qualify-references-to-generated-interfaces
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmckenzie
commented
Sep 3, 2025
AutomaticInterface/AutomaticInterface/AutomaticInterfaceGenerator.cs
Outdated
Show resolved
Hide resolved
This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names _where a single unambiguous match can be made between the symbol and the list of interfaces being generated_.
011fcc7 to
332a2db
Compare
simonmckenzie
commented
Sep 3, 2025
simonmckenzie
commented
Sep 3, 2025
simonmckenzie
commented
Sep 3, 2025
simonmckenzie
commented
Sep 3, 2025
f449545 to
dfcb5b7
Compare
- Change approach to use `ToDisplayParts`, which removes the need for regex parsing of generated code - Fix bug in `ReplaceWithInferredInterfaceName` where dots weren't being escaped - Add tests to ensure partially qualified references will be resolved correctly
dfcb5b7 to
28df788
Compare
|
This is ready for review again - I just had a last minute refactoring idea :) |
|
Could you be so kind and merge master into this? Than I will merge it as 6.x I think because it's potentially breaking |
|
Not a problem @ChristianSauer. I hope to get this done next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. See #87.
The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names where a single unambiguous match can be made between the symbol and the list of interfaces being generated.
For the example provided in #87, the code will now generate this output: