feat(deps): upgrade to Spring Boot 4 #4558
Conversation
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
|
Hmmm ... The de.codecentric.boot.admin.client.ClientServletApplicationTest hangs forever (in my fork build) ... Is this normal? 
Locally its "working" ... 
|
- the CountDownLatch.await should have a timeout too
|
I found a major problem ... may you guys have an idea ... Currently de.codecentric.boot.admin.client.config.SpringBootAdminClientRegistrationClientAutoConfigurationTest is failing for some of the defined "what kind of RegistrationClient is used" tests ... because de.codecentric.boot.admin.client.config.SpringBootAdminClientAutoConfiguration is mixing restclient and webclient and the bean-conditions which working with sb 3.5.x are no longer working because of the new splitting of the springboot dependencies ... may I'm wrong ... 
|
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
|
jolokia-support-spring is also not ready yet for spring-boot 4: jolokia/jolokia#866 |
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- the CountDownLatch.await should have a timeout too
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
SteKoe
force-pushed
the
feat/migrate-to-springboot-4
branch
from
c6403c2 to
13573fd
Compare
SteKoe
changed the title
SteKoe
changed the title
…ing-boot-admin into feat/migrate-to-springboot-4
|
I update the fork to M3 ... now some more new "incompatibilities" present ... all about jackson. For example in de.codecentric.boot.admin.server.utils.jackson.EndpointMixinTest 
The new org.springframework.boot.test.json.JacksonTester.initFields(Object, JsonMapper) accept only tools.jackson.databind.json.JsonMapper from jackson-databind-3.0.0-rc9. I can't find anything in spring's migration guide for this changes :-( https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Migration-Guide |
- cleaned also all "invalid" code-formattings from previous commits - one big problem in spring-boot-admin-server jackson's databind module 3.0.0-rc9 was included into spring which conflicts here and there with the old jackson stuff?!
1 participant
No description provided.