Update to radon 6.0.1 and remove unnecessary code #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dantevvp hey man, love that we are simplifying the code here but any chance we can get at least a few tests going? Would be nice just for sanity's sake 😄 |
RubyBrewsday
approved these changes
Jun 23, 2023
|
Urgh my bad @dantevvp for not getting to this sooner, just seeing now you did add in those specs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To execute this engine, we just need to install the package and run it. Just keep the codeclimate-radon bin file and adapt it.
Also, new alpine images do not support python 2, so I removed support for it here as well. I think it's safe to say at this point that if you're running Python 2 instead of 3 you can just use the previous radon version