Skip to content

Conversation

sebjulliand
Copy link
Member

Changes

This PR prevents the error notification from showing up when a Custom action has a prompt (either a custom prompt or a ! prompt) and that prompt is closed or cancelled.

How to test this PR

Run the test on a single item and on multiple items too

  1. Run an action with a prompt
  2. Close the prompt or click on Cancel
  3. Nothing must show up or happen

Checklist

  • have tested my change

@sebjulliand sebjulliand requested a review from a team October 1, 2025 09:04
@sebjulliand sebjulliand self-assigned this Oct 1, 2025
@sebjulliand sebjulliand added the enhancement New feature or request label Oct 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

👋 A new build is available for this PR based on 647c9b1.

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Did some testing of this PR - and your change seems to work.

However, I got some errors during testing:

  1. I ran an action with one command CRTCMD on a .cmd streamfile - no error, it compiled fine.
  2. I duplicated the action above and added a CPY command in front, so it had CPY and CRTCMD, and ran this action. Now it failed with the following errors:
image

and the terminal showed this:

Fetching errors for CJORGENS1/'.
Error: Failed fetching table: CPD0012:  Characters in qualifier beginning 'VSCODETEMP' not valid.
             CPD0014:  A matching apostrophe not found.
                                                       CPD0013:  A matching parenthesis not found.
              CPF0001:  Error found on *N command.

This must an old error, because it also occurs running on code from the master branch.
Maybe the *EVENTF file retrieve code failing to generate the correct object name?

.setOptions({
fullPage: true,
css: /* css */ `
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this code block has a wrong indentation?

@chrjorgensen
Copy link
Collaborator

@sebjulliand

either a custom prompt or a ! prompt

What is a ! prompt? Do you mean the ? prompt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants