Support for global RPGLINT configuration path #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add global lint config path support
Compiled in github codespaces
Add global lint config option
worksofliam
requested changes
Aug 14, 2025
There was a problem hiding this comment.
Hey, this is a great start! I am going to need some files removed from this PR:
package-extension.yml- please don't add any new actions to this PR. Perhaps in a separate one if this is something you want to see.- Please remove all
.vsixfiles. We don't want to check them into the repo.
Thanks! Then I will go in for a second review 😄
|
Requested changes completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for specifying a global RPGLINT config path using the new setting rpgle.globalLintConfigPath. If set, linter configs for libraries will be based on this path. This helps enforce company-wide lint standards.
Checklist
console.logs I addedThis is my first pull request to anything on github, ever. Please let me know if and where I went wrong so I contribute cleanly in the future.