Skip to content

chore(CR-29164): updated node.js, debian, jsonpath-plus, tar-fs, kubectl, brace-expansion #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore(CR-29164): updated node.js, debian, jsonpath-plus, tar-fs, kubectl, brace-expansion #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41258b8
updated node.js, debian, jsonpath-plus, tar-fs, kubectl, brace-expansion
vitalii-codefresh Jun 22, 2025
c30e323
empty
vitalii-codefresh Jun 23, 2025
ec73b07
empty
vitalii-codefresh Jun 23, 2025
e99e0ca
Update Dockerfile
vitalii-codefresh Jun 24, 2025
d4bf75f
upd alpine
vitalii-codefresh Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.11.0
v22.16.0
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ RUN pip install yq==${YQ_VERSION}
RUN pyinstaller --noconfirm --onefile --log-level DEBUG --clean --distpath /tmp/ $(which yq)

# kubectl binary
FROM bitnami/kubectl:1.30.6 AS kubectl
FROM bitnami/kubectl:1.33.1 AS kubectl

# Main
FROM node:22.11.0-alpine3.20
FROM node:22.16.0-alpine3.22
RUN apk --update add --no-cache \
bash \
ca-certificates \
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile-debian
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ RUN pip install yq==${YQ_VERSION}
RUN pyinstaller --noconfirm --onefile --log-level DEBUG --clean --distpath /tmp/ $(which yq)

# kubectl binary
FROM bitnami/kubectl:1.30.6 as kubectl
FROM bitnami/kubectl:1.33.1 as kubectl

# Main
FROM node:22.11.0-bullseye-slim
FROM node:22.16.0-bookworm-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does bullseye and bookworm provide the same list of binaries, including versions?
If not, it will affect customer's pipelines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which binaries we are talking about?

RUN apt update \
&& apt -y install \
apt-transport-https \
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile-debian-rootless
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ RUN pip install yq==${YQ_VERSION}
RUN pyinstaller --noconfirm --onefile --log-level DEBUG --clean --distpath /tmp/ $(which yq)

# kubectl binary
FROM bitnami/kubectl:1.30.6 as kubectl
FROM bitnami/kubectl:1.33.1 as kubectl

# Main
FROM node:22.11.0-bullseye-slim
FROM node:22.16.0-bookworm-slim
RUN apt update \
&& apt -y install \
bash \
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile-rootless
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ RUN pip install yq==${YQ_VERSION}
RUN pyinstaller --noconfirm --onefile --log-level DEBUG --clean --distpath /tmp/ $(which yq)

# kubectl binary
FROM bitnami/kubectl:1.30.6 as kubectl
FROM bitnami/kubectl:1.33.1 as kubectl

# Main
FROM node:22.11.0-alpine3.20
FROM node:22.16.0-alpine3.22
RUN apk --update add --no-cache \
bash \
ca-certificates \
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codefresh",
"version": "0.89.1",
"version": "0.89.2",
"description": "Codefresh command line utility",
"main": "index.js",
"preferGlobal": true,
Expand Down Expand Up @@ -42,7 +42,8 @@
"json-schema": "^0.4.0",
"ansi-regex": "^5.0.1",
"kubernetes-client/@kubernetes/client-node": ">=0.22.2",
"tough-cookie": "^4.1.3"
"tough-cookie": "^4.1.3",
"openid-client": "^4.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which deps are requiring it?
I see that it was present twice, should we not only upgrade lower version but also downgrade newer one? How safe is that?

Image

Copy link
Author

@vitalii-codefresh vitalii-codefresh Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

the same solution in kube-integration
image

},
"dependencies": {
"@codefresh-io/docker-reference": "^0.0.5",
Expand Down
Loading