feat: added persistent config item to redis handler Session
#9793
Conversation
ddevsr
force-pushed
the
session-redis-persistent
branch
from
59fe543 to
fdaa124
Compare
|
@ddevsr wait for the first PR to be accepted. There is no need to send an additional one in advance. What if your first PR changes? |
fix: test persistent parameter false
ddevsr
force-pushed
the
session-redis-persistent
branch
from
fdaa124 to
02c8284
Compare
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
Can we include this in the user guide? The following spot seems appropriate: https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/libraries/sessions.rst?plain=1#L719-L721
Something like:
Starting with v4.7.0, you can define a persistent connection::
public string $savePath = 'tcp://localhost:6379?persistent=1';
| $database = isset($query['database']) ? (int) $query['database'] : 0; | ||
| $timeout = isset($query['timeout']) ? (float) $query['timeout'] : 0.0; | ||
| $prefix = $query['prefix'] ?? null; | ||
| $persistent = isset($query['persistent']) ? (bool) $query['persistent'] : null; |
There was a problem hiding this comment.
Maybe we can do something like filter_var($query['persistent'], FILTER_VALIDATE_BOOLEAN) instead of just casting to bool? Although if we document this property, we can leave it as it is.
3 participants
Description
Needed #9792
Checklist: