-
Notifications
You must be signed in to change notification settings - Fork 26
[정상인] sprint6 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "React-\uC815\uC0C1\uC778-sprint6"
[정상인] sprint6 #111
Changes from all commits
4abd83a
21df6f4
d4f9836
cdd6e6e
33109c3
711a754
f6de88a
e8e16e8
e08d060
1953c5e
7380f4f
91b9e2c
ad500c0
2083dda
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,34 @@ | ||
| import js from '@eslint/js' | ||
| import globals from 'globals' | ||
| import reactHooks from 'eslint-plugin-react-hooks' | ||
| import reactRefresh from 'eslint-plugin-react-refresh' | ||
| import js from "@eslint/js"; | ||
| import globals from "globals"; | ||
| import reactHooks from "eslint-plugin-react-hooks"; | ||
| import reactRefresh from "eslint-plugin-react-refresh"; | ||
|
|
||
| export default [ | ||
| { ignores: ['dist'] }, | ||
| { ignores: ["dist"] }, | ||
| { | ||
| files: ['**/*.{js,jsx}'], | ||
| files: ["**/*.{js,jsx}"], | ||
| languageOptions: { | ||
| ecmaVersion: 2020, | ||
| globals: globals.browser, | ||
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| ecmaVersion: "latest", | ||
| ecmaFeatures: { jsx: true }, | ||
| sourceType: 'module', | ||
| sourceType: "module", | ||
| }, | ||
| }, | ||
| plugins: { | ||
| 'react-hooks': reactHooks, | ||
| 'react-refresh': reactRefresh, | ||
| "react-hooks": reactHooks, | ||
| "react-refresh": reactRefresh, | ||
| }, | ||
| rules: { | ||
| ...js.configs.recommended.rules, | ||
| ...reactHooks.configs.recommended.rules, | ||
| 'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]' }], | ||
| 'react-refresh/only-export-components': [ | ||
| 'warn', | ||
| "no-unused-vars": ["warn", { varsIgnorePattern: "^[A-Z_]" }], | ||
| "react-refresh/only-export-components": [ | ||
| "warn", | ||
| { allowConstantExport: true }, | ||
| ], | ||
| "no-console": ["warn", { allow: ["warn", "error"] }], | ||
| }, | ||
| }, | ||
| ] | ||
| ]; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .error-message { | ||
| color: #f74747; | ||
| padding: 6px 8px; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import "./ErrorMessage.style.css"; | ||
|
|
||
| const ErrorMessage = ({ errorMessage }) => { | ||
| return <div className="error-message">{errorMessage}</div>; | ||
| }; | ||
|
Comment on lines
+3
to
+5
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오호 에러메시지를 재사용 해보려는건가요? 😉 |
||
|
|
||
| export default ErrorMessage; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| .spinner-container { | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| height: 100px; | ||
| } | ||
|
|
||
| .spinner { | ||
| width: 40px; | ||
| height: 40px; | ||
| border: 4px solid rgba(0, 0, 0, 0.1); | ||
| border-left-color: var(--primary100); | ||
| border-radius: 50%; | ||
| animation: spin 1s linear infinite; | ||
| } | ||
|
|
||
| @keyframes spin { | ||
| to { | ||
| transform: rotate(360deg); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import "./LoadingSpinner.style.css"; | ||
|
|
||
| const LoadingSpinner = () => { | ||
| return ( | ||
| <div className="spinner-container"> | ||
| <div className="spinner" /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
Comment on lines
+3
to
+9
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 굿굿 ! 로딩 스피너도 많이 재사용될 것으로 보이네요 👍👍추 후 |
||
|
|
||
| export default LoadingSpinner; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,3 +58,9 @@ | |
| padding: 0 16px; | ||
| } | ||
| } | ||
|
|
||
| @media screen and (max-width: 767px) { | ||
| .nav-logo { | ||
| width: 100px; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btn-small-40에서40의 의미가 무엇인지 감이 잘 안잡히네요 ! 🤔btn-small,btn-medium등 스타일을 명확히 잘 나눴어요 !뒤에 붙는 숫자가 무엇을 의미하는지 잘 모르겠으나 혹시나
height를 의미하는거라면 구조적으로 자주 사용되는height-48과 같은 형태의 클래스도 만들어서 재사용해볼 수도 있겠네요 !