[김수경] sprint12#60
Open
suKyoung25 wants to merge 6 commits intocodeit-sprint-fullstack:express-김수경from
Hidden character warning
The head ref may contain hidden characters: "express-\uae40\uc218\uacbd-sprint12"
Open
Conversation
reach0908
approved these changes
Jul 9, 2025
reach0908
left a comment
There was a problem hiding this comment.
고생많으셨습니다.
전체적으로 테스트코드들 관련해서 챙겨보면 좋을듯한 부분들이 있습니다!
테스트를 위한 Mock 데이터들이 중복되는 경우가 많은데, 별도의 Mock데이터를 주입하기 위한 팩토리 함수를 만들면 좋을 것 같습니다!
describe 블록을 사용해서 연관된 테스트를 그룹화하면 좋을 것 같습니다!
beforeEach, afterEach 훅들을 잘 사용하는 것도 좋을 것 같아요!
| POST https://api.gxng.store/products | ||
| Content-Type: application/json | ||
| Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VySWQiOjEsImlhdCI6MTc0NjY4NDI0MCwiZXhwIjoxNzQ2Njg3ODQwfQ.SOESrOEWFQEA_1_MI6Ftwd8o_iZ9V3WwRfuUmIv4bTk | ||
| Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VySWQiOjIsImlhdCI6MTc1MDk5ODAwMCwiZXhwIjoxNzUxMDAxNjAwfQ.x96YtcM7GukyDtYKHsjkpa5w0LMPbs8vdNFvrmIPXac |
There was a problem hiding this comment.
[P0]
멘토링때 말씀드렸던 방향으로 수정하시면 좋을 것 같습니다!
| ### 사용자 정보 가져오기 | ||
| GET http://localhost:3000/users/me | ||
| Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VySWQiOjUsImlhdCI6MTc0NjgwMzI3NiwiZXhwIjoxNzQ2ODA2ODc2fQ.V4F6Pltu1ak_6CG3kjw0b78NeaoxvBggfPB3C5XYsuk | ||
| GET http://54.180.150.158/users/me |
There was a problem hiding this comment.
[P0]
Private IP는 노출시키면 좋지않을 것 같습니다!
추후 IP 주소가 변경되면 수정해야하기도하고 DNS에 등록한 도메인 네임으로 쓰시는게 좋을 것 같습니다!
| app.use("/favorites", favoriteController); //좋아요 컨트롤러 | ||
|
|
||
| app.use("/api-docs", swaggerUi.serve, swaggerUi.setup(swaggerSpec)); | ||
| // app.use("/api-docs", swaggerUi.serve, swaggerUi.setup(swaggerSpec)); |
There was a problem hiding this comment.
[P2]
왜 주석처리하셨을까요?
주석처리 한다음에는 TODO, FIXME 처럼 해당 주석을 풀어야할 때, 혹은 삭제해야할 때를 명시해주면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기본 요구사항
공통
백엔드 배포
프로젝트 구조 및 환경 설정
AWS S3를 이용한 파일 업로드 시스템 구축
AWS RDS를 사용한 데이터베이스 관리
AWS EC2에서의 애플리케이션 운영
백엔드 테스트 구현
프론트엔드 배포
심화 요구사항
테스트 구현
상품 이미지 업로드
AWS Route 53을 활용한 도메인 관리
SSL 인증서를 통한 HTTPS 연결 구현
멘토님께
(서비스 정상동작하는건 확인했습니다!)