Skip to content

Expand Codename One unit tests for core features #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Expand Codename One unit tests for core features #4124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d82effe
Add comprehensive unit tests for Codename One UI features
claude Nov 11, 2025
84b7b4d
Fix compilation errors in KeyEventsTest and LocalizationTest
claude Nov 11, 2025
e6c25c0
Fix second round of compilation errors in unit tests
claude Nov 11, 2025
b9b5746
Fix remaining LocalizationTest compilation errors
claude Nov 11, 2025
e889bb4
Fixed test cases
shai-almog Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions maven/core-unittests/src/test/java/com/codename1/components/StorageImageAsyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@
import com.codename1.io.Storage;
import com.codename1.junit.FormTest;
import com.codename1.junit.UITestBase;
import com.codename1.ui.Display;
import com.codename1.testing.TestUtils;
import com.codename1.ui.Image;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.Map;

Expand Down Expand Up @@ -53,7 +51,10 @@ void testBackgroundLoadPopulatesImageData() throws Exception {
StorageImageAsync image = StorageImageAsync.create("async", placeholder);
image.getInternal();

waitForImageData(image);
while(image.getInternal() == placeholder) {
TestUtils.waitFor(10);
}

assertArrayEquals(encoded, image.getImageData());

Image loaded = image.getInternal();
Expand Down Expand Up @@ -83,25 +84,6 @@ void testIsAnimationAlwaysTrue() {
assertTrue(image.isAnimation());
}

private void waitForImageData(StorageImageAsync image) throws Exception {
Method processSerialCalls = Display.class.getDeclaredMethod("processSerialCalls");
processSerialCalls.setAccessible(true);
long start = System.currentTimeMillis();
while (getImageDataField(image) == null) {
processSerialCalls.invoke(Display.getInstance());
if (System.currentTimeMillis() - start > 2000) {
fail("Timed out waiting for image data to load");
}
Thread.sleep(10);
}
}

private byte[] getImageDataField(StorageImageAsync image) throws Exception {
Field field = StorageImageAsync.class.getDeclaredField("imageData");
field.setAccessible(true);
return (byte[]) field.get(image);
}

private boolean isImageCreated(StorageImageAsync image) throws Exception {
Field field = StorageImageAsync.class.getDeclaredField("imageCreated");
field.setAccessible(true);
Expand Down
1 change: 1 addition & 0 deletions maven/core-unittests/src/test/java/com/codename1/testing/TestCodenameOneImplementation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ public TestCodenameOneImplementation(boolean timeoutSupported) {
public void setDisplaySize(int width, int height) {
this.displayWidth = width;
this.displayHeight = height;
sizeChanged(width, height);
}

public void setDeviceDensity(int density) {
Expand Down
Loading