Capture CN1SS error hooks and avoid unsupported charset #4158
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else | ||
| ra_log "FATAL: Failed to extract/decode CN1SS payload for test '$test'" | ||
| RAW_B64_OUT="$SCREENSHOT_TMP_DIR/${test}.raw.b64" | ||
| if cn1ss_extract_base64 "$TEST_LOG" "$test" > "$RAW_B64_OUT" 2>/dev/null; then | ||
| if [ -s "$RAW_B64_OUT" ]; then | ||
| head -c 64 "$RAW_B64_OUT" | sed 's/^/[CN1SS-B64-HEAD] /' | ||
| ra_log "Partial base64 saved at: $RAW_B64_OUT" | ||
| fi | ||
| fi | ||
| exit 12 | ||
| ra_log "WARN: No screenshot payload decoded for '$test' (png_chunks=${png_chunks})" | ||
| fi |
There was a problem hiding this comment.
When a test yields no PNG chunks (e.g., the app crashes before emitting CN1SS output or the chunks are corrupt), the loop now only logs a warning and continues. Because the run ends with exit $comment_rc (typically 0), the job can report success even though a test produced no actual screenshot, leaving missing_actual entries in the summary as the only signal. Previously this branch exited with a non‑zero status. Consider failing the run when a test’s PNG payload can’t be decoded so silent regressions aren’t marked green.
Useful? React with 👍 / 👎.
Android screenshot updatesCompared 7 screenshots: 1 matched, 1 updated, 2 missing references, 3 missing actuals.
Native Android coverage
|
Summary
Testing
Codex Task