Feature/prevent unexpected session switch on delete#29
Open
Mairs2 wants to merge 4 commits intocodepath:mainfrom
Open
Feature/prevent unexpected session switch on delete#29Mairs2 wants to merge 4 commits intocodepath:mainfrom
Mairs2 wants to merge 4 commits intocodepath:mainfrom
Conversation
Add defense-in-depth validation to ensure user input contains non-whitespace message
Adds a hover-activated copy button to code blocks that copies code to clipboard and shows a toast notification
onClick() mouseEventHandler activates switchMe() in Menuitem when menu item clicked. Add e.stopPropagation() to handleclick, drag and drop listeners, and all menu items to fix event b:ubbling issues in SessionItem component. Add delete confirmation for users before session is deleted and toast to confirm session deletion. Improves UX by preserving user's workflow context and This prevents unintended session switching when interacting with session menu items."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed event bubbling issues in SessionItem component by adding e.stopPropagation() to:
This prevents unintended session switching when interacting with session menu items.
Added deletion confirmation before user deletes session and toast to confirm that session has been deleted.
https://youtu.be/svjb5Nsa7sw
Fixes: #8