Skip to content

git diff -- .github/workflows/sync-leaderboard.yml - #533

Open
Akshu121796 wants to merge 1 commit into
codepvg:mainfrom
Akshu121796:fix/532-exclude-activity-state
Open

git diff -- .github/workflows/sync-leaderboard.yml#533
Akshu121796 wants to merge 1 commit into
codepvg:mainfrom
Akshu121796:fix/532-exclude-activity-state

Conversation

@Akshu121796

Copy link
Copy Markdown

Description

Fixes #532

Changes Made

  • Updated .github/workflows/sync-leaderboard.yml
  • Added git reset -q activity-state.json after the existing reset commands.
  • Prevents activity-state.json from being included in leaderboard sync commits.
  • Keeps activity-state.json exclusively managed by the inactivity analysis workflow.

Type of Change

  • Bug fix
  • New feature
  • UI/Visual update
  • Documentation update
  • Refactor

Testing

  • Tested locally
  • Tested on mobile viewport (if applicable)
  • No console errors introduced

Checklist

  • My code follows the project's coding style
  • I have formatted my code locally by running npx prettier --write . before submitting
  • I am submitting my PR from a dedicated feature/* branch, not the main branch
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have updated documentation if required
  • I have linked the relevant issue

Screenshots / Screen Recording

Not applicable — this is a GitHub Actions workflow change with no UI changes.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request.

Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully.

Formatting and Branching

  • Please confirm you have formatted your code locally using npx prettier --write . before requesting a review.
  • Ensure this PR is made from a feature/* branch and not main.

Note: This project is currently maintained by a solo maintainer, so reviews and responses may sometimes take a little time. Thanks for your patience.

@Akshu121796

Copy link
Copy Markdown
Author

Hello @jagdish-15 @codepvg
I've implemented the fix and opened a PR for #532.

The leaderboard sync workflow now explicitly resets activity-state.json after git add ., preventing it from being included in leaderboard sync commits.

PR: #533
If no chnages, PLease add the necessary labels
-type:bug
-gssoc:Approved

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: exclude activity-state.json from sync-leaderboard workflow commits

1 participant